From c0e1fd8562cc8f67fda6ea459b02f2a3b15c3501 Mon Sep 17 00:00:00 2001
From: Philippe Rolet <pr@dust.tt>
Date: Mon, 18 Mar 2024 17:00:56 +0100
Subject: [PATCH] [Poke] Check notion url from notion page in Poke (#4303)

* ux

* api call
---
 connectors/src/api/admin.ts                   |   6 +-
 .../poke/[wId]/data_sources/[name]/index.tsx  | 130 +++++++++++++++++-
 2 files changed, 131 insertions(+), 5 deletions(-)

diff --git a/connectors/src/api/admin.ts b/connectors/src/api/admin.ts
index 25078e93edf8..60432cbe4624 100644
--- a/connectors/src/api/admin.ts
+++ b/connectors/src/api/admin.ts
@@ -13,8 +13,8 @@ import { apiError, withLogging } from "@connectors/logger/withlogging";
 
 const whitelistedCommands = [
   {
-    majorCommand: "connectors",
-    command: "resume",
+    majorCommand: "notion",
+    command: "check-url",
   },
 ];
 
@@ -49,7 +49,7 @@ const _adminAPIHandler = async (
     return apiError(req, res, {
       api_error: {
         type: "invalid_request_error",
-        message: `Command not whitelisted: ${JSON.stringify(adminCommand)}`,
+        message: `Command not whitelisted: ${adminCommand.majorCommand} ${adminCommand.command}`,
       },
       status_code: 400,
     });
diff --git a/front/pages/poke/[wId]/data_sources/[name]/index.tsx b/front/pages/poke/[wId]/data_sources/[name]/index.tsx
index 2919e7581a23..31cfe442cab9 100644
--- a/front/pages/poke/[wId]/data_sources/[name]/index.tsx
+++ b/front/pages/poke/[wId]/data_sources/[name]/index.tsx
@@ -5,10 +5,15 @@ import {
   EyeIcon,
   Icon,
   InformationCircleIcon,
+  Input,
   Page,
   SliderToggle,
 } from "@dust-tt/sparkle";
-import type { CoreAPIDataSource, DataSourceType } from "@dust-tt/types";
+import type {
+  CoreAPIDataSource,
+  DataSourceType,
+  NotionCheckUrlResponseType,
+} from "@dust-tt/types";
 import type { WorkspaceType } from "@dust-tt/types";
 import type { ConnectorType } from "@dust-tt/types";
 import { ConnectorsAPI } from "@dust-tt/types";
@@ -26,7 +31,11 @@ import { useSubmitFunction } from "@app/lib/client/utils";
 import { getDisplayNameForDocument } from "@app/lib/data_sources";
 import { withSuperUserAuthRequirements } from "@app/lib/iam/session";
 import { useDocuments } from "@app/lib/swr";
-import { formatTimestampToFriendlyDate, timeAgoFrom } from "@app/lib/utils";
+import {
+  classNames,
+  formatTimestampToFriendlyDate,
+  timeAgoFrom,
+} from "@app/lib/utils";
 import logger from "@app/logger/logger";
 
 const { TEMPORAL_CONNECTORS_NAMESPACE = "" } = process.env;
@@ -282,6 +291,8 @@ const DataSourcePage = ({
     }
   };
 
+  const [notionUrlToCheck, setNotionUrlToCheck] = useState("");
+
   return (
     <div className="min-h-screen bg-structure-50">
       <PokeNavbar />
@@ -351,6 +362,13 @@ const DataSourcePage = ({
               />
             </div>
           )}
+          {dataSource.connectorProvider === "notion" && (
+            <NotionUrlChecker
+              notionUrlToCheck={notionUrlToCheck}
+              setNotionUrlToCheck={setNotionUrlToCheck}
+              owner={owner}
+            />
+          )}
           {dataSource.connectorProvider === "google_drive" && (
             <div className="mb-2 flex w-64 items-center justify-between rounded-md border px-2 py-2 text-sm text-gray-600">
               <div>PDF syncing enabled?</div>
@@ -513,4 +531,112 @@ const DataSourcePage = ({
   );
 };
 
+async function handleCheckNotionUrl(
+  url: string,
+  wId: string
+): Promise<NotionCheckUrlResponseType | null> {
+  const res = await fetch(`/api/poke/admin`, {
+    method: "POST",
+    headers: {
+      "Content-Type": "application/json",
+    },
+    body: JSON.stringify({
+      majorCommand: "notion",
+      command: "check-url",
+      args: {
+        url,
+        wId,
+      },
+    }),
+  });
+
+  if (!res.ok) {
+    const err = await res.json();
+    alert(
+      `Failed to check Notion URL: ${
+        err.error?.connectors_error?.message
+      }\n\n${JSON.stringify(err)}`
+    );
+    return null;
+  }
+  return res.json();
+}
+
+function NotionUrlChecker({
+  notionUrlToCheck,
+  setNotionUrlToCheck,
+  owner,
+}: {
+  notionUrlToCheck: string;
+  setNotionUrlToCheck: (value: string) => void;
+  owner: WorkspaceType;
+}) {
+  const [urlDetails, setUrlDetails] =
+    useState<NotionCheckUrlResponseType | null>(null);
+  return (
+    <div className="mb-2 flex flex-col gap-2 rounded-md border px-2 py-2 text-sm text-gray-600">
+      <div className="flex items-center gap-2 ">
+        <div>Check Notion URL</div>
+        <div className="grow">
+          <Input
+            placeholder="Notion URL"
+            onChange={setNotionUrlToCheck}
+            value={notionUrlToCheck}
+            name={""}
+          />
+        </div>
+        <Button
+          variant="secondary"
+          label="Check"
+          onClick={async () =>
+            setUrlDetails(
+              await handleCheckNotionUrl(notionUrlToCheck, owner.sId)
+            )
+          }
+        />
+      </div>
+      <div className="text-gray-800">
+        <p>
+          Check if we have access to the Notion URL, if it's a page or a DB, and
+          provide a few details.
+        </p>
+        {urlDetails && (
+          <div className="flex flex-col gap-2 rounded-md border pt-2 text-lg">
+            <span
+              className={classNames(
+                "font-bold",
+                urlDetails.page || urlDetails.db
+                  ? "text-emerald-800"
+                  : "text-red-800"
+              )}
+            >
+              {(() => {
+                if (urlDetails.page) {
+                  return "Page found";
+                }
+                if (urlDetails.db) {
+                  return "Database found";
+                }
+                return "Not found";
+              })()}
+            </span>
+            {(urlDetails.page || urlDetails.db) && (
+              <div>
+                <span className="font-bold">Details:</span>{" "}
+                <span>
+                  {urlDetails.page ? (
+                    <JsonViewer value={urlDetails.page} rootName={false} />
+                  ) : (
+                    <JsonViewer value={urlDetails.db} rootName={false} />
+                  )}
+                </span>
+              </div>
+            )}
+          </div>
+        )}
+      </div>
+    </div>
+  );
+}
+
 export default DataSourcePage;