dust-apps: more stability + observability (#4577)

* dust-apps: more stability + observability * remove streaming retries
dust-tt · Apr 4, 2024 · c6ad5b1 · c6ad5b1
1 parent e3e4bad
commit c6ad5b1
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 116 deletions.
diff --git a/core/Cargo.lock b/core/Cargo.lock
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -47,7 +47,7 @@ urlencoding = "2.1"
 url = "2.3"
 dns-lookup = "1.0"
 async-stream = "0.3"
-eventsource-client = "0.11"
+eventsource-client = "0.12"
 tera = "1.17"
 fancy-regex = "0.11"
 rustc-hash = "1.1"

diff --git a/core/src/providers/anthropic.rs b/core/src/providers/anthropic.rs
@@ -541,11 +541,7 @@ impl AnthropicLLM {
                                     "Anthropic API Error: {}",
                                     event.error.to_string()
                                 ),
-                                retryable: Some(ModelErrorRetryOptions {
-                                    sleep: Duration::from_millis(500),
-                                    factor: 1,
-                                    retries: 1,
-                                }),
+                                retryable: None,
                             })?;
                             break 'stream;
                         }
@@ -557,7 +553,10 @@ impl AnthropicLLM {
                     }
                 },
                 Err(error) => {
-                    Err(anyhow!("Error streaming from Anthropic: {:?}", error))?;
+                    Err(anyhow!(
+                        "Error streaming tokens from Anthropic: {:?}",
+                        error
+                    ))?;
                     break 'stream;
                 }
             }

diff --git a/core/src/providers/mistral.rs b/core/src/providers/mistral.rs
@@ -331,7 +331,7 @@ impl MistralAPIError {
     }
 
     pub fn retryable_streamed(&self) -> bool {
-        self.retryable()
+        false
     }
 }
 
@@ -497,11 +497,7 @@ impl MistralAILLM {
                                                     })?,
                                                     false => Err(ModelError {
                                                         message: error.message(),
-                                                        retryable: Some(ModelErrorRetryOptions {
-                                                            sleep: Duration::from_millis(500),
-                                                            factor: 1,
-                                                            retries: 1,
-                                                        }),
+                                                        retryable: None,
                                                     })?,
                                                 }
                                                 break 'stream;

diff --git a/core/src/providers/openai.rs b/core/src/providers/openai.rs
@@ -280,11 +280,7 @@ pub async fn streamed_completion(
                                             })?,
                                             false => Err(ModelError {
                                                 message: error.message(),
-                                                retryable: Some(ModelErrorRetryOptions {
-                                                    sleep: Duration::from_millis(500),
-                                                    factor: 1,
-                                                    retries: 1,
-                                                }),
+                                                retryable: None,
                                             })?,
                                         }
                                         break 'stream;
@@ -666,11 +662,7 @@ pub async fn streamed_chat_completion(
                                             })?,
                                             false => Err(ModelError {
                                                 message: error.message(),
-                                                retryable: Some(ModelErrorRetryOptions {
-                                                    sleep: Duration::from_millis(500),
-                                                    factor: 1,
-                                                    retries: 1,
-                                                }),
+                                                retryable: None,
                                             })?,
                                         }
                                         break 'stream;

diff --git a/types/src/front/lib/core_api.ts b/types/src/front/lib/core_api.ts
@@ -365,6 +365,8 @@ export class CoreAPI {
         logger.error(
           {
             error: e,
+            errorStr: JSON.stringify(e),
+            errorSource: "createRunStream",
           },
           "Error streaming chunks"
         );

diff --git a/types/src/front/lib/dust_api.ts b/types/src/front/lib/dust_api.ts
@@ -291,6 +291,8 @@ export async function processStreamedRunResponse(
       logger.error(
         {
           error: e,
+          errorStr: JSON.stringify(e),
+          errorSource: "processStreamedRunResponse",
         },
         "Error streaming chunks."
       );
@@ -670,6 +672,8 @@ export class DustAPI {
         logger.error(
           {
             error: e,
+            errorStr: JSON.stringify(e),
+            errorSource: "postUserMessage",
           },
           "Error streaming chunks."
         );