Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KW-search] Google Drive: Standardize parents and internal ID #9256

Open
philipperolet opened this issue Dec 10, 2024 · 3 comments
Open

[KW-search] Google Drive: Standardize parents and internal ID #9256

philipperolet opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@philipperolet
Copy link
Contributor

philipperolet commented Dec 10, 2024

Goal is to ensure for Google Drive that:

  • Parent ids used in the parents[] array in core data_source_nodes and internal ids from connectors should now match node_id in core data_sources_nodes (= document_id for docs, table_id for tables, folder_id for folders);
  • the convention that parents[0] = node_id should be enforced.

The connector should be thoroughly inspected. If there is a convention mismatch, fix it; explained in details in #9069

As noted here : https://github.com/dust-tt/dust/pull/9261/files#r1879852550 , we should add parent_id parameter in upserts as part of this card once parents are standardized.

@philipperolet
Copy link
Contributor Author

we'll need to migrate folders too here since they're already written on

@tdraier
Copy link
Contributor

tdraier commented Dec 12, 2024

Found a lot of inconsistencies in existing parents array, may need to be fixed first : #9250

@philipperolet philipperolet self-assigned this Dec 12, 2024
@philipperolet
Copy link
Contributor Author

As per IRL, #9250 and #9256 will be handled at the same time, using the common migration script of #9277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants