Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt our Rinnai Control-R password #3

Open
buckzilla opened this issue Feb 7, 2022 · 2 comments
Open

Encrypt our Rinnai Control-R password #3

buckzilla opened this issue Feb 7, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@buckzilla
Copy link

I am concerned with my Rinnai login credentials sitting in plain text on the Homebridge config file. Is it possible that they can be point in time encrypted/decrypted? This is how most network vendors handle this problem (passwords in text config files).

@buckzilla buckzilla added the enhancement New feature or request label Feb 7, 2022
@dustindclark dustindclark added the help wanted Extra attention is needed label Feb 11, 2022
@dustindclark
Copy link
Owner

While this is absolutely a valid request, I'd like to point out a couple of things.

  1. The Rinnai API is not in anyway secured...so anyone with your email address and IP address can control your water heater. This is a huge vulnerability that I can't believe that they haven't addressed. This plugin, however, enforces authentication before allowing control.
  2. A would-be attacker would have to have access to your local network to see this information. If they have this, they can already control your devices and/or modify your Homebridge config.

@dustindclark
Copy link
Owner

Rinnai finally secured their API, so point 1 made above is no longer valid.

oyarzun pushed a commit to oyarzun/homebridge-rinnai-controlr that referenced this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants