generated from homebridge/homebridge-plugin-template
-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported "Heat To" / "Heating To" and several other bug fixes #26
Open
zimuliu
wants to merge
16
commits into
dustindclark:master
Choose a base branch
from
zimuliu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper rounding for controllers with imperial units
Fixed the UUID generation
Avoided to create `RinnaiControlrPlatformAccessory` for each poll
Fixed the incorrect use of _.throttle
* Added the support of heating state ("Heating to" when the combustation is ON) and the current water temperature (from the outlet temperature). * Improved the stepped target temperature calculation for controllers using imperial unit. * Avoid adding recirulation button if the heater is not configured for it yet
Fix heating state
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple changes on the forked repo
_.throttle
RinnaiControlrPlatformAccessory
for each polldevice
Example when the combustion is on
Example when the combustion is off