Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported "Heat To" / "Heating To" and several other bug fixes #26

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

zimuliu
Copy link

@zimuliu zimuliu commented May 16, 2024

This PR contains multiple changes on the forked repo

  • Supported "Heat To" / "Heating To" (the issue reported in Change “Heating to” to “Heat to” #2)
    • Always set Heat as target state (will show "Heat to" in Home.app)
    • Set Heat as current state when combustion is on (will show "Heating to" in Home.app and the number will turn Orange); otherwise, set Off as current state (the number will stay White)
    • Display the outlet temperature as the current temperature, so that it better match the UX of ("Heat to" / "Heating to"). Note that we pull the outlet temperature at different frequencies, so that we don't congest the API for setting a new target temperature.
  • Fixed the incorrect use of _.throttle
  • Avoided to create RinnaiControlrPlatformAccessory for each poll
  • Fixed the HomeKit Accessory UUID generation
  • remove unused device
  • Use dynamic step sizes for controllers with imperial units
    • The controllers in US/Canada use step of 2, like 98F/100F/102F/etc. for the temperature below 110F. We need to use the right step number during the rounding, so that we can avoid the rounding error.
  • Changed the default max/min from the manual (98/120)

Example when the combustion is on
image

Example when the combustion is off
image

Use proper rounding for controllers with imperial units
Avoided to create `RinnaiControlrPlatformAccessory` for each poll
Fixed the incorrect use of _.throttle
* Added the support of heating state ("Heating to" when the combustation is ON) and the current water temperature (from the outlet temperature).
* Improved the stepped target temperature calculation for controllers using imperial unit.
* Avoid adding recirulation button if the heater is not configured for it yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant