Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recirculation only mode #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Windscar
Copy link

Thank you for creating the Rinnai plugin!

I was looking for a way to disable the thermostat service that's being reported to homekit because it's confusing Siri voice commands.

I need to run recirculation every day and almost never set the temperature.

I added a RecircualtionOnly option to settings that disables the thermostat and only exposes the switch for recirculation.
Please edit as you see fit

@ayybe
Copy link

ayybe commented Aug 27, 2024

Recirc is all I need too! Do you mind adding a NPM page so we can grab this as a plugin in HB?

@ayybe
Copy link

ayybe commented Aug 27, 2024

Trying to manually use your version without luck (maybe since yours is 1.024 vs 1.026 is latest?):

$ rm -rf /var/lib/homebridge/node_modules/homebridge-rinnai-controlr/*

$ wget https://github.com/Windscar/homebridge-rinnai-controlr/archive/recirc_only.tar.gz

$ tar xf recirc_only.tar.gz -C /var/lib/homebridge/node_modules/homebridge-rinnai-controlr --strip-components 1

@sagar-a16z
Copy link

Recirc is all I need too! Do you mind adding a NPM page so we can grab this as a plugin in HB?

I won't be able to get to doing that any time soon unfortunately.

Trying to manually use your version without luck (maybe since yours is 1.024 vs 1.026 is latest?):

$ rm -rf /var/lib/homebridge/node_modules/homebridge-rinnai-controlr/*

$ wget https://github.com/Windscar/homebridge-rinnai-controlr/archive/recirc_only.tar.gz

$ tar xf recirc_only.tar.gz -C /var/lib/homebridge/node_modules/homebridge-rinnai-controlr --strip-components 1

I did it manually as well. I use homeassistant and portainer to manage my homebridge instance.
But basically, I followed instructions here https://github.com/homebridge/homebridge#plugin-development to npm link my local plugin copy to homebridge's node_modules directory.

As long as you have dist directory in your local copy, and you've made the link to node_modules, homebridge should be able to pick up the plugin. Make sure to disable or delete the other official one though.

I think I had to add this config to my config.json in the homebridge dir manually as well otherwise the accessory wasn't persisting.

        {
            "username": "yourusername",
            "password": "yourpassword",
            "recirculationDuration": 15,
            "temperatureUnits": "F",
            "minimumTemperature": 120,
            "maximumTemperature": 140,
            "recirculationOnly": true,
            "platform": "RinnaiControlR"
        }

I can explore publishing it to npm at some point but probably not anytime soon.

@sagar-a16z
Copy link

I also have some bug fixes that I should update this PR with.

@Windscar
Copy link
Author

@ayybe I've updated this with a bug fix that updates the state of the recirc switch correctly.

If you're going to run it manually, update the package.json

"displayName": "Homebridge Rinnai Control-R-new",
"name": "homebridge-rinnai-controlr-new",
"version": "1.0.27",

and settings.ts

export const PLUGIN_NAME = 'homebridge-rinnai-controlr-new';

That should avoid conflicts with the official one.

@ayybe
Copy link

ayybe commented Aug 28, 2024

Awesome, TY! That worked (Rxp199in w/ rwm200 wifi) @dustindclark do you mind reviewing this PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants