Code Reviews

[ngolapnguyen]

• Not sure why gamepad is kept here? I think it should be in the tokyo-gamepad project
• Why is EventType an enum? Shouldn't it be a type/interface?
• Type/interface names should be more consistent. E.g. IConfig -> Config

[haongo138]

Not sure why gamepad is kept here? I think it should be in the tokyo-gamepad project

Currently, in lib, user has two choices:

• Implement an algorithm in setGamePlan to consume & respond to event from the map (sent from server) by using gamepad obj
• Manually controls the ship via tokyo-gamepad using exposed gamepad object

[haongo138]

Why is EventType an enum? Shouldn't it be a type/interface?

I think EventType is only used as a constant represents type of event from server

[haongo138]

Type/interface names should be more consistent. E.g. IConfig -> Config

yep, I will update this one after done discussing about two questions above