Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy version #10

Merged
merged 8 commits into from
Aug 20, 2021
Merged

Conversation

vgoliber
Copy link
Collaborator

Adding NumPy version for an educational resource for training/sales.

Summary of changes:

  • Added demo_numpy.py: BQM construction function uses NumPy; update README to discuss
  • Remove usage of AdjVectorBQM

@vgoliber vgoliber requested a review from hhtong August 17, 2021 08:11
Copy link
Contributor

@hhtong hhtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Mostly just a few minor comments for readability.

demo_numpy.py Outdated Show resolved Hide resolved
demo_numpy.py Outdated Show resolved Hide resolved
demo_numpy.py Outdated Show resolved Hide resolved
demo_numpy.py Show resolved Hide resolved
@vgoliber
Copy link
Collaborator Author

@hhtong I addressed all of your feedback, let me know if there's any other changes you'd like to see.

demo.py Outdated Show resolved Hide resolved
demo.py Show resolved Hide resolved
demo_numpy.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vgoliber
Copy link
Collaborator Author

@hhtong I addressed all of your feedback, let me know if there's any other changes you'd like to see.

@vgoliber vgoliber merged commit 04d221c into dwave-examples:main Aug 20, 2021
@vgoliber vgoliber deleted the add-numpy-version branch August 20, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants