-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow install from conda repository directly #144
Comments
It would be great have D-Wave available in conda. Being i conda should ivrease the visibility and adoption of D-Wave tools among scientific users of Python who often promarily use conda. Some advantages of conda are
|
Hi everybody, I've coincidentally started working on the sdk separate from this request as I needed it myself but happy to join forces. |
PR is at conda-forge/staged-recipes#16694 but will take some time. |
Some packages use the following: cwd = os.path.abspath(os.path.dirname(__file__))
if not os.path.exists(os.path.join(cwd, 'PKG-INFO')):
try:
from Cython.Build import cythonize
USE_CYTHON = True
except ImportError:
USE_CYTHON = False
else:
USE_CYTHON = False Could someone explain what is happening here? Should I use Cython or not? |
Would someone from here like to co-maintain them? |
Some packages have files that are licensed differently than the overall package. Does anyone have some more info here on whether that is to stay and if that should be explicitly mentioned?
Also, are there any other files like this? |
|
|
|
Hi @BastianZim, Thanks for doing this! I'll answer your questions, in order, here.
This is a deprecated workaround we used many years ago. Some packages have we modernized to use PEP-517 (see Short answer: use Cython.
That would be great. Someone from the Tools team. I can volunteer myself (@randomir), but we can wait for @arcondello and @hhtong to chime in. Alternatively, we're happy (and grateful!) with you maintaining it, if you have the bandwidth for that. We can ping you before (or shortly after) we release a new version of the SDK.
That's a good catch. These are to support Windows builds.
@boothby, can you answer this one, please?
@kotarotanahashi is
I'm not sure, we'll have to check. IIRC, 9.0+ does not work for us, or at least not until we update the |
I direct-included |
Hi @randomir (Great profile pic by the way 😄), I will answer in a list just to make it easier.
|
You can't just delete the folder; it's a C extension and the build will fail if it doesn't exist. I'll take care of this today. |
Oh yeah, you're right - didn't check all folders. Thanks! |
One other problem: Is there a way to use them without the dependency on each other? Otherwise, I'll have to see if there's a workaround. |
Sounds good, @BastianZim. Thank you! FWIW, we can fix/resolve most of these for the next minor release of Ocean, if you're willing to wait a few weeks. The One (short-term) workaround is to use an older |
Of course, no timeline on my side I'm just tinkering around. Happy to wait until you're ready. Would you mind pinging here once everything is published? Ok, would completely follow your lead here about which approach to choose RE |
Hi everybody, just wanted to check in and see if there have been any developments that would allow us to start the packaging process or if we should still wait further? |
Hi @BastianZim , thanks for the great work! If you want to maintain, that would be great! |
Hey @BastianZim, thanks again for doing this! To answer your question:
So, you're not fully unblocked yet, but some progress is possible. |
Hi @randomir thanks for your reply!
|
Hi @BastianZim, Re: 4, no, IIRC. The closest to that is a custom setup step during which we install one of the Re: 5, Ocean 5, early April. |
Hi everybody, I'm making good progress but am stuck on conda-forge/staged-recipes#18266. Could someone please have a look at it? |
Hi everybody, I've now made some more progress and have added all of the packages that are not blocked by something. The following are still missing:
|
Hi everyone, since the new release doesn't depend on Pyqubo anymore, I have submitted this package and it was just merged. |
Great news! Thanks for contributing Ocean to Conda, @BastianZim! Just note that the pyqubo removal is temporary, until they update it for dimod 0.11. |
My pleasure! Yeah and I'm tackling that now but since it's not included I wanted to get this out before. Do you have any connections to the author of it? |
Here's our issue on pyqubo, for tracking: recruit-communications/pyqubo#150. |
Ok had a look and it seems like pyqubo is very straightforward so I'll add that now so that we're prepared for the future. |
Current Problem
In order to install dwave-ocean-sdk in a conda environment it is necessary to first install pip (and related packages) and then use that to install dwave-ocean-sdk.
Proposed Solution
Get dwave-ocean-sdk added to the conda or conda-forge repository so that a user can do a simple
conda install dwave-ocean-sdk
in order to install.The text was updated successfully, but these errors were encountered: