Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Generate Notification icons for Android #144

Open
ath0mas opened this issue Dec 7, 2020 · 1 comment · May be fixed by #146
Open

Feature: Generate Notification icons for Android #144

ath0mas opened this issue Dec 7, 2020 · 1 comment · May be fixed by #146

Comments

@ath0mas
Copy link
Contributor

ath0mas commented Dec 7, 2020

Hello here,
I recently started to work on a feature branch to add Android Notification icons generation.

It mostly consists of a smallIcon, white and transparent, in 5 sizes, and an optional largeIcon in 1 size and no restriction on colors.
See example refs about it: 1, 2.

As a first step, I implemented and tested it the same way adaptive icons are added to the main generate exec, with new path and boolean options.

  • What do you think about it?

Unlike app icons, and aside making it work with a default notification source icon (like notification.png), it would be useful to be able to generate various other ones.

  • To do so, should it be the existing generate that be changed to be able to not generate any app icon, but only more notification icons, given appropriate options?
  • or, should we go for a new entrypoint to generate only notification icons?
@ath0mas
Copy link
Contributor Author

ath0mas commented Dec 9, 2020

Please @dwmkerr is that ok for you or any orientation to give me?
I would like to create a PR for it around next week.

@ath0mas ath0mas linked a pull request Dec 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant