Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDAPI-80] [C++][IPF] Implement custom fields in InstrumentProfile #52

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

AnatolyKalin
Copy link
Collaborator

It is required to refactor InstrumenProfile to allow custom fields to be retrieved from it.

What must be done:

  • The API should be migrated to Graal SDK v1.1.22+
  • InstrumentProfile should be represented as a JavaObjectHandle<InstrumentProfile>.
  • All methods that accept/return this class must return its handle.
  • All methods in InstrumentProfile should be referred to IsolatedInstrumentProfile.

@ttldtor ttldtor marked this pull request as ready for review July 19, 2024 21:19
@ttldtor
Copy link
Collaborator

ttldtor commented Jul 19, 2024

  • The API was migrated to Graal SDK v1.1.22
  • Added methods:
    • InstrumentProfile::getField
    • InstrumentProfile::setField
    • InstrumentProfile::getNumericField
    • InstrumentProfile::setNumericField
    • InstrumentProfile::getDateField
    • InstrumentProfile::setDateField
    • InstrumentProfile::getNonEmptyCustomFieldNames
  • [BREAKING]: All toString methods can now throw exceptions.

@ttldtor ttldtor requested a review from stdcion July 19, 2024 21:24
@ttldtor ttldtor merged commit 93c2144 into main Jul 23, 2024
21 checks passed
@ttldtor ttldtor deleted the feature/MDAPI-80 branch July 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants