skipping tests more correctly

dxFeed · Apr 17, 2024 · 10a0a9c · 10a0a9c
1 parent 5ac9722
commit 10a0a9c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/DXFeedFrameworkTests/DXAsyncLastTest.swift b/DXFeedFrameworkTests/DXAsyncLastTest.swift
@@ -93,7 +93,7 @@ final class DXAsyncLastTest: XCTestCase {
     }
 
     func testIndexedEventTask() async throws {
-        throw XCTSkip("""
+        try XCTSkipIf(true, """
                      Skiped
 """)
         let date = Calendar.current.date(byAdding: .month, value: -1, to: Date())!

diff --git a/DXFeedFrameworkTests/DXLastEventsSubscribedTest.swift b/DXFeedFrameworkTests/DXLastEventsSubscribedTest.swift
@@ -76,7 +76,6 @@ final class DXLastEventsSubscribedTest: XCTestCase {
             return
         }
         let type = Candle.self
-        let subscription = try feed?.createSubscription([type])
 
         do {
             let nillList = try feed?.getTimeSeriesIfSubscribed(type: type,
@@ -85,6 +84,7 @@ final class DXLastEventsSubscribedTest: XCTestCase {
                                                                toTime: toTime)
             XCTAssertNil(nillList)
         }
+        let subscription = try feed?.createSubscription([type])
         do {
             // wrong sub time
             try subscription?.addSymbols(TimeSeriesSubscriptionSymbol(symbol: candleSymbol, fromTime: toTime))

diff --git a/DXFeedFrameworkTests/DXPromiseTest.swift b/DXFeedFrameworkTests/DXPromiseTest.swift
@@ -275,7 +275,7 @@ final class DXPromiseTest: XCTestCase {
     }
 
     func testCompleteExceptPromise() throws {
-        throw XCTSkip("""
+        try XCTSkipIf(true, """
                       Graal doesn't have impl for ExceptionMapper.toJava.
                       and always throws exception illegalStateException
 """)

diff --git a/DXFeedFrameworkTests/IPFTests.swift b/DXFeedFrameworkTests/IPFTests.swift
@@ -241,7 +241,8 @@ STOCK,EREGL:TR,EREĞLİ DEMİR VE ÇELİK FABRİKALARI1 T.A.Ş.,TR,XIST,XIST,TRY
 
     func testConnection() throws {
         guard let address = ProcessInfo.processInfo.environment["ipf_address"] else {
-            throw XCTSkip("Please input address")
+            try XCTSkipIf(true, "Please input address")
+            return
         }
         let expectationCollector = expectation(description: "Collector")
         expectationCollector.assertForOverFulfill = false

diff --git a/DXFeedFrameworkTests/IsolateTest.swift b/DXFeedFrameworkTests/IsolateTest.swift
@@ -18,7 +18,7 @@ final class IsolateTest: XCTestCase {
     }
 
     func testCleanup() throws {
-        throw XCTSkip("Just for manual running")
+        try XCTSkipIf(true, "Just for manual running")
         let isolate = Isolate.shared
         isolate.cleanup()
         let sec = 5