fix: leaks in schedule

dxFeed · Jun 10, 2024 · 1734719 · 1734719
1 parent 5b4c87a
commit 1734719
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/DXFeedFramework/Native/Schedule/NativeDay.swift b/DXFeedFramework/Native/Schedule/NativeDay.swift
@@ -10,6 +10,6 @@ import Foundation
 class NativeDay: NativeBox<dxfg_day_t> {
     deinit {
         let thread = currentThread()
-        _ = try? ErrorCheck.nativeCall(thread, dxfg_JavaObjectHandler_release(thread, &(native.pointee.handler)))
+        _ = try? ErrorCheck.nativeCall(thread, dxfg_Day_release(thread, native))
     }
 }
diff --git a/DXFeedFramework/Native/Schedule/NativeSchedule.swift b/DXFeedFramework/Native/Schedule/NativeSchedule.swift
@@ -128,6 +128,10 @@ class NativeSchedule {
         scheduleDay.startTime = try ErrorCheck.nativeCall(thread, dxfg_Day_getStartTime(thread, day))
         scheduleDay.endTime = try ErrorCheck.nativeCall(thread, dxfg_Day_getEndTime(thread, day))
         let sessions = try ErrorCheck.nativeCall(thread, dxfg_Day_getSessions(thread, day)).value()
+        defer {
+            _ = try? ErrorCheck.nativeCall(thread, dxfg_SessionList_release(thread, sessions))
+        }
+
         let count = sessions.pointee.size
         for index in 0..<Int(count) {
             if let element = sessions.pointee.elements[index] {
@@ -147,7 +151,7 @@ class NativeSchedule {
         let isTraiding = try ErrorCheck.nativeCall(thread, dxfg_Session_isTrading(thread, session))
         let day = try ErrorCheck.nativeCall(thread, dxfg_Session_getDay(thread, session)).value()
         defer {
-            _ = try? ErrorCheck.nativeCall(thread, dxfg_JavaObjectHandler_release(thread, &(day.pointee.handler)))
+            _ = try? ErrorCheck.nativeCall(thread, dxfg_Day_release(thread, day))
         }
         let yearMonthDay = try ErrorCheck.nativeCall(thread, dxfg_Day_getYearMonthDay(thread, day))
         let type = dxfg_session_type_t(UInt32(nativeType))

diff --git a/DXFeedFramework/Native/Schedule/NativeSession.swift b/DXFeedFramework/Native/Schedule/NativeSession.swift
@@ -10,6 +10,6 @@ import Foundation
 class NativeSession: NativeBox<dxfg_session_t> {
     deinit {
         let thread = currentThread()
-        _ = try? ErrorCheck.nativeCall(thread, dxfg_JavaObjectHandler_release(thread, &(native.pointee.handler)))
+        _ = try? ErrorCheck.nativeCall(thread, dxfg_Session_release(thread, native))
     }
 }
diff --git a/DXFeedFramework/Native/Utils/NativeTimeUtil.swift b/DXFeedFramework/Native/Utils/NativeTimeUtil.swift
@@ -23,8 +23,8 @@ class NativeTimeUtil {
         let result = try ErrorCheck.nativeCall(thread,
                                                dxfg_TimeFormat_format(thread,
                                                                       timeFormat.native,
-                                                                      value))
-        return String(pointee: result)
+                                                                      value))        
+        return try String(nullable: result).value()
     }
 
 }
diff --git a/build.gradle b/build.gradle
@@ -6,7 +6,7 @@ repositories {
     }
 }
 
-def native_version = '1.1.16'
+def native_version = '1.1.18'
 def name = 'graal-native-sdk'
 dependencies {
     implementation(group: 'com.dxfeed', name: "${name}", version: "${native_version}", classifier: 'aarch64-osx', ext: 'zip')