Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Bad namespaced class names from apex-node break test retry logic #1362

Closed
JonnyPower opened this issue Jul 19, 2023 · 2 comments · Fixed by #1365
Closed

Bad namespaced class names from apex-node break test retry logic #1362

JonnyPower opened this issue Jul 19, 2023 · 2 comments · Fixed by #1365
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JonnyPower
Copy link
Contributor

Describe the bug

When using sfp apextests:trigger to run tests in a namespaced org, the test retry logic fails due to apex class full names being provided by upstream @salesforce/apex-node library (forcedotcom/salesforcedx-apex#296)

Waiting for an upstream fix in 4.x is problematic, so opening issue to track work with a fix within dx@scale rather than waiting for upstream fix.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scratch org with a namespace
  2. Create unit tests that will hit a timeout or lock exception (I'm replicating reliably on our ISV product, but could also replicate with contention on org custom settings I suspect)
  3. Run unit tests
  4. apextests:trigger will run async then report failures and queue failed classes for a retry
  5. class names are invalid (NS.NS__Foo instead of NS.Foo)

Expected behavior
A clear and concise description of what you expected to happen.

  1. Should be able to retry test failures in namespaced test classes

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added the analysis To be decided on how to solution/fix label Jul 19, 2023
@JonnyPower
Copy link
Contributor Author

@azlam-abdulsalam can you assign to me? created this for branch issue reference

@azlam-abdulsalam azlam-abdulsalam added bug Something isn't working and removed analysis To be decided on how to solution/fix labels Jul 19, 2023
@azlam-abdulsalam
Copy link
Contributor

Thanks for the detailed bug report @JonnyPower

JonnyPower added a commit to Traction-Rec/sfpowerscripts that referenced this issue Jul 21, 2023
JonnyPower added a commit to Traction-Rec/sfpowerscripts that referenced this issue Jul 21, 2023
JonnyPower added a commit to Traction-Rec/sfpowerscripts that referenced this issue Jul 21, 2023
azlam-abdulsalam pushed a commit that referenced this issue Jul 24, 2023
* fix(namespace): fix namespaces on reported class names

Related to: #1362

* fix(apex-test): retry on Internal SF Error

* fix(apex-test): update decision record
@azlam-abdulsalam azlam-abdulsalam added this to the July 23 milestone Jul 25, 2023
azlam-abdulsalam pushed a commit that referenced this issue Aug 11, 2023
* fix(namespace): fix namespaces on reported class names

Related to: #1362

* fix(apex-test): retry on Internal SF Error

* fix(apex-test): update decision record
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants