Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root logger set as NOSET in __init__.py causing trouble with user-defined logging solutions or other libraries #128

Closed
Ivansstyle opened this issue Apr 20, 2024 · 1 comment · Fixed by #129
Labels
bug Something isn't working

Comments

@Ivansstyle
Copy link
Contributor

Describe the bug
init.py file contains root logging setting, which sets it to NOSET, which causes issues with other libraries where logging level is not set but logger is used

To Reproduce
Steps to reproduce the behavior:
Use in combination in project with library like spotipy

The resulting error is:
Unexpected logs and no control over logging overall

Expected behavior
Library should not change the logging level of the logging root

@dylanljones
Copy link
Owner

dylanljones commented Feb 2, 2025

Hey, sorry for being inactive for so long. Thanks for pointing this out, I will change the logger config asap!

Edit: didn't see you made a PR, thanks for fixing this:)

dylanljones added a commit that referenced this issue Feb 2, 2025
Fix: root logging level is set as loging.NOSET as part of library initialisation. #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants