Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-DYM gas fees handing in x/txfees #1387

Open
keruch opened this issue Nov 4, 2024 · 0 comments
Open

Non-DYM gas fees handing in x/txfees #1387

keruch opened this issue Nov 4, 2024 · 0 comments

Comments

@keruch
Copy link
Contributor

keruch commented Nov 4, 2024

We handle AMM and IRO fees, but we're still left with gas fees. The current design is:

  1. DYM fees go to staking rewards
  2. Non-DYM fees go to x/txfees to be swapped and burned once an epoch

We need to unify the approach. The non-DYM fees are handled in the x/txfees AnteHandler. In theory, this should be simply changed for

txFeesKeeper.ChargeFeesFromPayer(ctx, acc.GetAddress(), fees, nil)

The problem is that we might have custom coins for fees (which are non-fee tokens). Currently such tokens are burned, but in case of changing the API, we're going to send them to the community pool. This potentially leads to the community pool spamming (as mentioned in the ADR). Though this statement is not proven and requires additional research.

@mtsitrin mtsitrin changed the title Non-DYM fees handing in x/txfees Non-DYM gas fees handing in x/txfees Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant