Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alternative option for promo elements #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added alternative option for promo elements #8

wants to merge 1 commit into from

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Sep 11, 2018

Resolves #1

@muskie9
Copy link
Member

muskie9 commented Mar 20, 2019

@mak001 @korthjp17 is this still needed?

@muskie9
Copy link
Member

muskie9 commented Apr 24, 2019

closing for now

@muskie9 muskie9 closed this Apr 24, 2019
@korthjp17 korthjp17 reopened this Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #8   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity        6      6           
=======================================
  Files             2      2           
  Lines            33     34    +1     
=======================================
+ Hits             33     34    +1
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementPromos.php 100% <100%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85839ce...64d031b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #8   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity        6      6           
=======================================
  Files             2      2           
  Lines            33     34    +1     
=======================================
+ Hits             33     34    +1
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementPromos.php 100% <100%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85839ce...64d031b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alternate layout option
3 participants
@mak001 @muskie9 @korthjp17