Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: SilverStripe 4 compatibility #28

Open
1 of 7 tasks
robbieaverill opened this issue Feb 1, 2017 · 3 comments
Open
1 of 7 tasks

Enhancement: SilverStripe 4 compatibility #28

robbieaverill opened this issue Feb 1, 2017 · 3 comments

Comments

@robbieaverill
Copy link

This is a placeholder issue for SS4 compatibility.

Pre-requisites

  • Branch current master off to 1 or similar for maintaining the current version
  • Update/add composer branch alias to 2.0.x-dev

Requirements

  • Add namespacing for module including upgrader mapping file
  • PSR-2 code formatting (looks like its mostly done)
  • Implement core namespaces, update configuration (including CI builds), tests and template locations
  • Add PSR-4 autoloader (inc. move code/ to src/ for consistency)
  • Update documentation

Implications

  • Minimum PHP version becomes 5.5
@robbieaverill
Copy link
Author

@dljoseph if you wouldn't mind doing the branching and update the composer alias, I'm happy to make PRs for the rest of the changes required.

"extra": {
    "branch-alias": {
        "dev-master": "2.0.x-dev"
    }
}

@dljoseph
Copy link
Contributor

Hi Robbie, Thanks for this. Sorry I'm a bit late in responding. I'll do that today.

@dljoseph
Copy link
Contributor

dljoseph commented Oct 31, 2017

Hi @robbieaverill that's done. Branch 1.0 created for maintaining compatible SilverStripe 3.x version, composer.json branch-alias added to master branch for SilverStripe 4.x. Go ahead and submit your PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants