Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] DeepKoopman regressor #7

Closed
Enderdead opened this issue Mar 5, 2021 · 2 comments
Closed

[enhancement] DeepKoopman regressor #7

Enderdead opened this issue Mar 5, 2021 · 2 comments

Comments

@Enderdead
Copy link

Hello,
I took a quick look at your library and got surprised that no deepkoopman technique was implemented.
Do you plan to include it in the future ? ( Even if this may lead to include a deep-learning dependency to your project. )

I would be happy to try to submit this feature if you interested to include it.

Best regards

@eurika-kaiser
Copy link
Member

Hi!

Thanks for your interest in the pykoopman package!
The package architecture has been developed to allow for extensions such as deep learning via plugins. If you would like to pursue this (which would be very cool!), I suggest to create a separate GitHub project, in which you develop this and I’d be happy to include your extension in the README. Note that the pykoopman package is still under development and I can let you know once there is a stable version (~ 1 month latest).

@Enderdead
Copy link
Author

Hi,
Thank you for your answer.
I'm looking forward to your final version and your stable API before starting my development.
When I will be happy with my work, I will reopen another issue in this repo.
Good luck for the end of your development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants