From 04912f4234b2d3fd8edb8633c1e8c5ce731ac011 Mon Sep 17 00:00:00 2001 From: trymzet Date: Mon, 19 Aug 2024 12:18:28 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8=20Linting?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gitignore | 2 +- CHANGELOG.md | 3 +-- CONTRIBUTING.md | 7 +++++-- config.yaml.example | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 2f85b87ca..f2bed40d8 100644 --- a/.gitignore +++ b/.gitignore @@ -186,4 +186,4 @@ profiles.yaml *.secret # AWS -.aws \ No newline at end of file +.aws diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f2ba8656..e70f5016c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,13 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] - - Added new version of `Genesys` connector and test files. - Added new version of `Outlook` connector and test files. - Added new version of `Hubspot` connector and test files. - Added `Mindful` connector and test file. - ### Added - Added `sap_to_parquet` Prefect flow. @@ -71,6 +69,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed `catch_extra_separators()` from `SAPRFCV2` class ### Fixed + - Fixed the typo in credentials in `SQLServer` source ## [0.4.3] - 2022-04-28 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9762884eb..63951b332 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -76,19 +76,20 @@ Commit messages should: - start with one of the following verbs, capitalized, immediately after the summary emoji: "Add", "Update", "Remove", "Fix", "Rename", and, sporadically, other ones, such as "Upgrade", "Downgrade", or whatever you find relevant for your particular situation - contain a useful summary of what the commit is doing - See [this article](https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/) to understand the basics of commit naming. + See [this article](https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/) to understand the basics of commit naming. ## Submitting a PR 1. [Fork the repo](https://github.com/dyvenia/viadot/fork) 2. Uncheck the "Copy the `main` branch only" box -3 Follow the setup outlined above +3. Follow the setup outlined above 4. Checkout a new branch ```console # Make sure that your base branch is `2.0`. git switch 2.0 && git checkout -b ``` + 5. Add your changes 6. Sync your fork with the `dyvenia` repo @@ -98,11 +99,13 @@ Commit messages should: git switch 2.0 git rebase upstream/2.0 ``` + 7. Push the changes to your fork ```console git push --force ``` + 8. [Submit a PR](https://github.com/dyvenia/viadot/compare/2.0...main) into the `2.0` branch. Make sure to read & check all relevant checkboxes in the PR description! diff --git a/config.yaml.example b/config.yaml.example index 66b967c02..4b8c81b48 100644 --- a/config.yaml.example +++ b/config.yaml.example @@ -76,7 +76,7 @@ sources: client_id: your_client_id client_secret: your_client_secret tenant_id: your_tenant_id - + - hubspot_dev: class: Hubspot credentials: