Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectors Migration: Check Pending PRs and Merge #910

Closed
6 tasks done
fdelgadodyvenia opened this issue May 29, 2024 · 5 comments
Closed
6 tasks done

Connectors Migration: Check Pending PRs and Merge #910

fdelgadodyvenia opened this issue May 29, 2024 · 5 comments
Assignees
@Diego-H-S @fdelgadodyvenia
Labels
2.0 viadot 2.0

Comments

@fdelgadodyvenia
Copy link
Contributor

fdelgadodyvenia commented May 29, 2024 •
edited by Diego-H-S
Loading

  • big_query
  • sales_force
  • supermetrics
  • pass code checker
  • create unit tests
  • create integration tests

Create a PR for each source!
@fdelgadodyvenia fdelgadodyvenia changed the title PRs approvals Connectors Migration: PRs approvals May 29, 2024
@fdelgadodyvenia fdelgadodyvenia changed the title Connectors Migration: PRs approvals Connectors Migration: PRs Approvals May 29, 2024
@fdelgadodyvenia fdelgadodyvenia changed the title Connectors Migration: PRs Approvals Connectors Migration: Check Pending PRs and Merge May 29, 2024
@fdelgadodyvenia fdelgadodyvenia added the 2.0 viadot 2.0 label May 29, 2024
@fdelgadodyvenia
Copy link
Contributor Author

sales_force.txt
test_salesforce.txt

supermetrics.txt
test_integration_supermetrics.txt
test_unit_supermetrics.txt

bigquery.txt

test_bigquery.txt

@fdelgadodyvenia
Copy link
Contributor Author

Supermetrics is ready to PR. After passing checker and unit test coverage.

@Diego-H-S
Copy link
Collaborator

BigQuery PR opened.

@Diego-H-S Diego-H-S mentioned this issue Sep 17, 2024
Merged
5 tasks
@Diego-H-S
Copy link
Collaborator

BigQuery PR: #1035

@Diego-H-S Diego-H-S mentioned this issue Sep 18, 2024
Merged
5 tasks
@Diego-H-S
Copy link
Collaborator

Salesforce PR: #1036

@trymzet trymzet closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Diego-H-S Diego-H-S

@fdelgadodyvenia fdelgadodyvenia

Labels
2.0 viadot 2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trymzet @Rafalz13 @Diego-H-S @fdelgadodyvenia