Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add BigQuery source and Prefect tasks #1035

Merged
merged 26 commits into from
Sep 30, 2024
Merged

✨ Add BigQuery source and Prefect tasks #1035

merged 26 commits into from
Sep 30, 2024

Conversation

Diego-H-S
Copy link
Collaborator

Summary

BigQuery connector migration from viadot 1 to viadot 2.

issue: #910

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

src/viadot/orchestration/prefect/flows/__init__.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/bigquery_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/bigquery_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the responses.

@Diego-H-S Diego-H-S requested a review from trymzet September 19, 2024 09:29
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing left with the api_connection() method, otherwise pls create an issue to track the rest and link it in relevant conversations so I can close them, and then we can merge.

@angelika233 angelika233 requested a review from trymzet September 25, 2024 10:37
@trymzet
Copy link
Contributor

trymzet commented Sep 25, 2024

@angelika233 can you rebase pls, and make sure that checks pass? Otherwise, seems like this is good to go.

@mgardzinski mgardzinski force-pushed the bigquery_2.0 branch 3 times, most recently from ea10e2a to f08ff76 Compare September 26, 2024 14:36
@trymzet trymzet changed the title Bigquery 2.0 ✨ Add BigQuery source and Prefect tasks Sep 27, 2024
@mgardzinski mgardzinski self-requested a review September 27, 2024 10:34
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments

src/viadot/sources/__init__.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/bigquery.py Outdated Show resolved Hide resolved
tests/unit/test_bigquery.py Outdated Show resolved Hide resolved
@trymzet trymzet merged commit 0568da1 into 2.0 Sep 30, 2024
3 checks passed
@trymzet trymzet deleted the bigquery_2.0 branch September 30, 2024 13:05
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants