Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Salesforce source and Prefect tasks #1036

Merged
merged 18 commits into from
Sep 27, 2024
Merged

✨ Add Salesforce source and Prefect tasks #1036

merged 18 commits into from
Sep 27, 2024

Conversation

Diego-H-S
Copy link
Collaborator

Summary

Salesforce connector migration from viadot 1 to viadot 2.

Issue: #910

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
tests/unit/test_salesforce.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at the comments.

@Diego-H-S Diego-H-S requested a review from trymzet September 20, 2024 10:44
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments.

src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
src/viadot/sources/salesforce.py Outdated Show resolved Hide resolved
tests/unit/test_salesforce.py Outdated Show resolved Hide resolved
@mgardzinski mgardzinski requested a review from trymzet September 25, 2024 12:09
@trymzet
Copy link
Contributor

trymzet commented Sep 25, 2024

@mgardzinski Can you pls rebase and make sure checks pass? Otherwise, it seems this is good to go.

@mgardzinski mgardzinski self-requested a review September 27, 2024 09:40
@trymzet trymzet changed the title Sales force 2.0 ✨ Add Salesforce source and Prefect tasks Sep 27, 2024
@trymzet trymzet merged commit a9710c9 into 2.0 Sep 27, 2024
3 checks passed
@trymzet trymzet deleted the sales_force_2.0 branch September 27, 2024 16:00
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants