-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Salesforce
source and Prefect tasks
#1036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
trymzet
requested changes
Sep 18, 2024
tests/integration/orchestration/prefect/flows/test_salesforce.py
Outdated
Show resolved
Hide resolved
Diego-H-S
force-pushed
the
sales_force_2.0
branch
from
September 19, 2024 10:27
06bb4e6
to
4361462
Compare
Diego-H-S
commented
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a look at the comments.
trymzet
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments.
tests/integration/orchestration/prefect/flows/test_salesforce.py
Outdated
Show resolved
Hide resolved
@mgardzinski Can you pls rebase and make sure checks pass? Otherwise, it seems this is good to go. |
mgardzinski
force-pushed
the
sales_force_2.0
branch
from
September 25, 2024 14:04
e7a0ef0
to
a46cc8d
Compare
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
mgardzinski
force-pushed
the
sales_force_2.0
branch
from
September 26, 2024 15:34
4d2fc50
to
22cd412
Compare
5 tasks
trymzet
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Salesforce connector migration from viadot 1 to viadot 2.
Issue: #910
Importance
Required by the migration project.
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md