Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Mediatool source and Prefect tasks #1038

Merged
merged 18 commits into from
Sep 27, 2024
Merged

✨ Add Mediatool source and Prefect tasks #1038

merged 18 commits into from
Sep 27, 2024

Conversation

Diego-H-S
Copy link
Collaborator

Summary

Mediatool connector migration from viadot 1 to viadot 2.

Issue: #906

Also added the utility function join_dfs needed in the connector.

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Diego-H-S Diego-H-S requested a review from trymzet September 18, 2024 07:00
@Diego-H-S Diego-H-S mentioned this pull request Sep 18, 2024
Closed
3 tasks
trymzet
trymzet requested changes Sep 19, 2024
View reviewed changes
src/viadot/orchestration/prefect/flows/mediatool_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/mediatool_to_adls.py Show resolved Hide resolved
tests/integration/orchestration/prefect/flows/test_mediatool.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/mediatool.py Show resolved Hide resolved
src/viadot/sources/mediatool.py Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/mediatool.py Show resolved Hide resolved
src/viadot/sources/mediatool.py Outdated Show resolved Hide resolved
tests/unit/test_mediatool.py Outdated Show resolved Hide resolved
src/viadot/sources/mediatool.py Show resolved Hide resolved
Diego-H-S
Diego-H-S commented Sep 20, 2024
View reviewed changes
Copy link
Collaborator Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at it.

@Diego-H-S Diego-H-S requested a review from trymzet September 20, 2024 10:44
trymzet
trymzet requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added remaining comments.

This was referenced Sep 26, 2024
Open
Open
Open
@trymzet trymzet changed the title Mediatool 2.0 ✨ Add Mediatool source and Prefect tasks Sep 27, 2024
@mgardzinski mgardzinski requested a review from trymzet September 27, 2024 14:28
trymzet
trymzet approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@trymzet trymzet merged commit f2cf164 into 2.0 Sep 27, 2024
3 checks passed
@trymzet trymzet deleted the mediatool_2.0 branch September 27, 2024 15:50
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgardzinski mgardzinski mgardzinski left review comments

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
2.0 viadot 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diego-H-S @trymzet @mgardzinski