Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra credentials in SQL base class - Encrypt and TrustServerCertificate #1095

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Add extra credentials in SQL base class - Encrypt and TrustServerCertificate #1095

merged 7 commits into from
Oct 22, 2024

Conversation

angelika233
Copy link
Contributor

Summary

Changed possible string values for parameter if exists in the sql base. Delete doesn't make sense and append is needed.

Added extra credentials for sql connection

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@angelika233 angelika233 requested a review from trymzet October 21, 2024 09:15
trymzet
trymzet requested changes Oct 21, 2024
View reviewed changes
src/viadot/sources/base.py Outdated Show resolved Hide resolved
@angelika233 angelika233 changed the title 🐛 Changed possible options for if_exists in the create_table in the base sql Add extra credentials in SQL base class - Encrypt and TrustServerCertificate Oct 22, 2024
@angelika233 angelika233 requested a review from trymzet October 22, 2024 08:05
@trymzet trymzet merged commit 7fe5e53 into 2.0 Oct 22, 2024
3 checks passed
@trymzet trymzet deleted the duckdb_params branch October 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelika233 @trymzet