Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django 1.3 STATIC_URL #28

Open
munhitsu opened this issue Jan 29, 2011 · 8 comments
Open

django 1.3 STATIC_URL #28

munhitsu opened this issue Jan 29, 2011 · 8 comments

Comments

@munhitsu
Copy link

Django 1.3 introduces STATIC_URL as a standard approach for app static files.
So from now on there are two paths for not dynamic files:
MEDIA_URL - more like uploaded files
STATIC_URL - statics delivered with app

At this point there are two issues with django-css.

  1. defeulting to context MEDIA_URL
    I guess it should be enough jus to remove templatetags/compress.py lines:
    if 'MEDIA_URL' in context:
    media_url = context['MEDIA_URL']
    else:
  2. During development STATIC_ROOT is often empty as it is being dynamically filled by static app. A standard practice is to have all files collected to STATIC_ROOT only on development

It might be useful to either document this limitation or get real static file path while in development mode (runserver)

@hedberg
Copy link

hedberg commented Feb 1, 2011

I made a pull request regarding the media url issue earlier. You can have a look here #27

@munhitsu
Copy link
Author

munhitsu commented Feb 2, 2011

Works perfect. Thanks!

@twoolie
Copy link

twoolie commented Apr 15, 2011

i dont know about you guys, but i store site-wide sass files in STATIC_ROOT and now these files are not found by django-css. They are however served perfectly by django static files.

django-css needs to considder files in STATIC_ROOT before any files in STATICFILES_DIRS

@xster
Copy link

xster commented May 10, 2011

Django-css's copy of django-compressor is old in general. Django-compressor took care of this in recent versions

@twoolie
Copy link

twoolie commented May 10, 2011

is anyone merging django-compressor into django-css regularly/semi-regularly?

@hedberg
Copy link

hedberg commented May 21, 2011

You might wanna take a look at https://github.com/jezdez/django_compressor/. It now has a precompiler filter with which you can add support for external commands (sass, coffescript etc). Works well in my first test and have support for Django 1.3 / staticfiles.

@ghost
Copy link

ghost commented May 21, 2011

Yes, it works really well in my tests. Except one small problem where I can't get it to find my static files in my app. Other than that there's 0 problems. :)

@ghost
Copy link

ghost commented May 22, 2011

I tracked down the bug I spoke of above here, and have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants