Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consent was revoked when updating to a new version #141

Open
shankari opened this issue Nov 3, 2016 · 6 comments
Open

Consent was revoked when updating to a new version #141

shankari opened this issue Nov 3, 2016 · 6 comments

Comments

@shankari
Copy link
Contributor

shankari commented Nov 3, 2016

While testing the upgrade from 1.2.0 to 1.3.0, the consent appeared to be revoked.

2016-11-02 23:08:23.990 emission[634:468206] reqConsent = 2016-07-14, currConfig.approval_date = (null)
2016-11-02 23:08:23.991 emission[634:468206] DEBUG: reqConsent = 2016-07-14, currConfig.approval_date = (null)

But while restarting with the same version, it worked.

2016-11-02 23:19:35.435 emission[638:470332] BEMDataCollection:pluginInitialize singleton -> initialize statemachine and delegate
2016-11-02 23:19:35.438 emission[638:470332] data has 114 bytes, str has size 114
2016-11-02 23:19:35.465 emission[638:470332] reqConsent = 2016-07-14, currConfig.approval_date = 2016-07-14
2016-11-02 23:19:35.465 emission[638:470332] DEBUG: reqConsent = 2016-07-14, currConfig.approval_date = 2016-07-14
2016-11-02 23:19:35.481 emission[638:470332] isConsented = YES
2016-11-02 23:19:35.481 emission[638:470332] DEBUG: isConsented = YES
@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

missing_consent_start_state.gz

@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

Trying to upgrade to 1.4.0 to see if this is reproducible.

@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

Not reproducible after bumping to 1.4.0.

2016-11-02 23:26:06.972 emission[642:471685] reqConsent = 2016-07-14, currConfig.approval_date = 2016-07-14
2016-11-02 23:26:06.972 emission[642:471685] DEBUG: reqConsent = 2016-07-14, currConfig.approval_date = 2016-07-14

I am going to ensure that the other phone(s) have the release version and will see if the app store update reproduces this. if so, I have to make an emergency fix.

@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

Happened on android as well, bumping up from 1.2.0 -> 1.4.0.
Don't see anything in the logs, may need to add more logging.

no_consent_android_either.gz

@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

  • Should add more logging
  • Should check for consent on UI startup as well, instead of relying on the localStorage. Otherwise, if we do get a prompt, clicking on it doesn't do anything.

@shankari
Copy link
Contributor Author

shankari commented Nov 3, 2016

Like an idiot, I reconsented instead of debugging further.
We'll have to see if it happens again.
Tests to try when that happens:

  • Email the usercache to myself
  • Try force sync to force the init code to run again

shankari added a commit to shankari/e-mission-phone that referenced this issue Nov 3, 2016
@shankari
Bump up the version number
775afd0 
This was bumped up twice by mistake because I wanted to test
e-mission/e-mission-data-collection#141
but didn't end up bumping back down.

Oh well, there are a lot of changes in this release... :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shankari