-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity is not displayed in the Place card - version 1.2.2 #882
Comments
@shankari This is a fundamental issue. Can you pls prioritise this one? |
@MaliheTabasi please retry with 1.2.3 - note that the more complicated P0 issue #880 was that all the place activities were being associated with the first place. |
@shankari Thank you for letting me know. I will try version 1.2.3. |
@shankari I still faced the same issue with version 1.2.3 as can be seen in the attached screen recording. video6190368009043838836.mp4 |
@MaliheTabasi I cannot reproduce this on 1.2.3 (see attached video) time_use_entries_added.movCan you:
If you are still able to reproduce, and I am not, this is likely to be related to your data. |
@shankari Yes, The version is 1.2.3. I retried. I realised that it works for places and trips before a specific place with end time 11:59pm, but it does not work properly for places after that. The activities I tried to add to places after that specific place were incorrectly displayed in that specific place. I will send you my token so that you can reproduce this error. |
@shankari I still see the issue of wrong place end time in the app. Please see the screenshot below. Place end time is expected to be 11:59pm but it is 1:51pm. |
@MaliheTabasi I'm pretty sure this is an overnight place. The issue of how to represent and deal with overnight places is still open We had de-prioritized that design based on this comment
However, I think we do need to address it before going live, since sleeping overnight is a very common use case. |
@MaliheTabasi can you re-retry? I just tried and it works fine. The 11:59 place is gone (replaced by untracked time) and the activities have been matched to their correct places.
The issue was that I had not reset the pipeline for your token. Note that the fix for #880 was primarily on the server side; we were creating the confirmed timeline incorrectly. So to fix, I needed to reset the pipeline and reconstruct the confirmed timeline. Fortunately OpenPATH is set up to do this without losing user data. Rather than overloading the server, I went through and reset pipelines in order of last trip date. Your last trip was from 11th Apr, so it was towards the end of the queue. And it looks like I marked it as reset without actually resetting it. Oops! I reset again today morning, the timeline has been regenerated and everything should work now. |
Closing this since resetting the pipeline has fixed the issue |
@shankari Please watch the below screen recording. I tried to add activity to the last Place card and it is not displayed there.
Moreover, the prefilled end time is expected to be 11:59PM, but it is 10:25PM.
video6167770506767370496.mp4
The text was updated successfully, but these errors were encountered: