Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity is not displayed in the Place card - version 1.2.2 #882

Closed
MaliheTabasi opened this issue Apr 9, 2023 · 10 comments
Closed

Activity is not displayed in the Place card - version 1.2.2 #882

MaliheTabasi opened this issue Apr 9, 2023 · 10 comments

Comments

@MaliheTabasi
Copy link

MaliheTabasi commented Apr 9, 2023

@shankari Please watch the below screen recording. I tried to add activity to the last Place card and it is not displayed there.
Moreover, the prefilled end time is expected to be 11:59PM, but it is 10:25PM.

video6167770506767370496.mp4
@MaliheTabasi
Copy link
Author

@shankari This is a fundamental issue. Can you pls prioritise this one?

@shankari
Copy link
Contributor

@MaliheTabasi please retry with 1.2.3 - note that the more complicated P0 issue #880 was that all the place activities were being associated with the first place.

@MaliheTabasi
Copy link
Author

@shankari Thank you for letting me know. I will try version 1.2.3.

@MaliheTabasi
Copy link
Author

@shankari I still faced the same issue with version 1.2.3 as can be seen in the attached screen recording.

video6190368009043838836.mp4

@shankari
Copy link
Contributor

shankari commented Apr 18, 2023

@MaliheTabasi I cannot reproduce this on 1.2.3 (see attached video)

time_use_entries_added.mov

Can you:

  • confirm that the version is in fact 1.2.3? You can check the version in TestFlight and also in the app (Profile -> Developer Zone -> Scroll to the bottom)
  • retry one more time? Check if the first place entry ends at midnight - that is the underlying issue

If you are still able to reproduce, and I am not, this is likely to be related to your data.
Please send me your token via email and I will log in as you and see if I can reproduce.

@MaliheTabasi
Copy link
Author

@MaliheTabasi I cannot reproduce this on 1.2.3 (see attached video)

time_use_entries_added.mov
Can you:

  • confirm that the version is in fact 1.2.3? You can check the version in TestFlight and also in the app (Profile -> Developer Zone -> Scroll to the bottom)
  • retry one more time? Check if the first place entry ends at midnight - that is the underlying issue

If you are still able to reproduce, and I am not, this is likely to be related to your data. Please send me your token via email and I will log in as you and see if I can reproduce.

@shankari Yes, The version is 1.2.3. I retried. I realised that it works for places and trips before a specific place with end time 11:59pm, but it does not work properly for places after that. The activities I tried to add to places after that specific place were incorrectly displayed in that specific place. I will send you my token so that you can reproduce this error.

@MaliheTabasi
Copy link
Author

@shankari Please watch the below screen recording. I tried to add activity to the last Place card and it is not displayed there. Moreover, the prefilled end time is expected to be 11:59PM, but it is 10:25PM.

video6167770506767370496.mp4

@shankari I still see the issue of wrong place end time in the app. Please see the screenshot below. Place end time is expected to be 11:59pm but it is 1:51pm.

photo1681888397

@shankari
Copy link
Contributor

@MaliheTabasi I'm pretty sure this is an overnight place. The issue of how to represent and deal with overnight places is still open
#871 (comment)
#871 (comment)

We had de-prioritized that design based on this comment

#871 (comment)

Taha and I had a meeting and decided that activities that starts form one day and ends in another day are not essential for our study. So, we can stop worrying about that and instead focus on fixing the errors with the current basic time-use feature.

However, I think we do need to address it before going live, since sleeping overnight is a very common use case.
Opening a new issue for it.
#891

@shankari
Copy link
Contributor

@MaliheTabasi can you re-retry? I just tried and it works fine. The 11:59 place is gone (replaced by untracked time) and the activities have been matched to their correct places.

11:59 place is gone Activities have been moved to the correct following places
simulator_screenshot_EC3B715B-7F84-447E-B866-7EC29B85FE84 simulator_screenshot_EAE27B9B-B846-4E78-AC3F-66F1C4E52CB1

The issue was that I had not reset the pipeline for your token. Note that the fix for #880 was primarily on the server side; we were creating the confirmed timeline incorrectly. So to fix, I needed to reset the pipeline and reconstruct the confirmed timeline. Fortunately OpenPATH is set up to do this without losing user data.

Rather than overloading the server, I went through and reset pipelines in order of last trip date. Your last trip was from 11th Apr, so it was towards the end of the queue. And it looks like I marked it as reset without actually resetting it. Oops!

I reset again today morning, the timeline has been regenerated and everything should work now.
As an aside, this also fixes #890 as you can see from the screenshots

@shankari
Copy link
Contributor

Closing this since resetting the pipeline has fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants