Skip to content

Commit

Permalink
Remove WriterProxyData from public APIs (#163)
Browse files Browse the repository at this point in the history
* Refs #21301. Improvements.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21301. Fix typo in test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21301. Remove import of `WriterProxyData`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21301. Using new PublicationBuiltinTopicData

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21301. Rename header to `WriterDiscoveryStatus.hpp`.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
  • Loading branch information
MiguelCompany and richiware authored Jul 17, 2024
1 parent 26b5d39 commit 1d811c3
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 22 deletions.
1 change: 1 addition & 0 deletions fastdds_python/src/swig/fastdds.i
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ namespace xtypes {
%include "fastdds/rtps/attributes/RTPSParticipantAttributes.i"
%include "fastdds/rtps/attributes/ReaderAttributes.i"
%include "fastdds/rtps/attributes/WriterAttributes.i"
%include "fastdds/rtps/common/RemoteLocators.i"
%include "fastdds/rtps/common/SequenceNumber.i"
%include "fastdds/rtps/common/SampleIdentity.i"
%include "fastdds/rtps/common/WriteParams.i"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
#include "fastdds/dds/builtin/topic/BuiltinTopicKey.hpp"
%}

%include "fastdds/rtps/builtin/data/BuiltinTopicKey.hpp"
%include "fastdds/dds/builtin/topic/BuiltinTopicKey.hpp"
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
#include "fastdds/dds/builtin/topic/PublicationBuiltinTopicData.hpp"
%}

%include "fastdds/rtps/builtin/data/PublicationBuiltinTopicData.hpp"
%include "fastdds/dds/builtin/topic/PublicationBuiltinTopicData.hpp"

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

%{
#include "fastdds/rtps/writer/WriterDiscoveryInfo.hpp"
#include "fastdds/rtps/writer/WriterDiscoveryStatus.hpp"
%}

%include "fastdds/rtps/writer/WriterDiscoveryInfo.hpp"
%include "fastdds/rtps/writer/WriterDiscoveryStatus.hpp"
2 changes: 1 addition & 1 deletion fastdds_python/test/api/test_datareader.py
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ def test_get_liveliness_changed_status(datareader):
def test_get_matched_publication_data(datareader):
"""
This test checks:
- DataWriter::get_matched_publication_data
- DataReader::get_matched_publication_data
"""
pub_data = fastdds.PublicationBuiltinTopicData()
ih = fastdds.InstanceHandle_t()
Expand Down

0 comments on commit 1d811c3

Please sign in to comment.