Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal builtin topics as DdsTopic(s) [20039] #60

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

juanlofer-eprosima
Copy link
Contributor

PR #56 introduced a regression in which internal builtin topics were added as DistributedTopic instead of DdsTopic. As a consequence, these were not well processed when an allowlist was being provided (casting to DdsTopic failed).

Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (76bd140) 65.15% compared to head (aefb4fa) 65.15%.

Files Patch % Lines
fastddsspy_tool/src/cpp/tool/Backend.cpp 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          22       22           
  Lines        1105     1105           
  Branches      389      389           
=======================================
  Hits          720      720           
  Misses        136      136           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanlofer-eprosima juanlofer-eprosima merged commit 1e3cc74 into main Nov 23, 2023
18 of 19 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the hotfix/builtin-dds-topics branch November 23, 2023 16:06
@juanlofer-eprosima juanlofer-eprosima changed the title Add internal builtin topics as DdsTopic(s) Add internal builtin topics as DdsTopic(s) [20039] Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants