Refs #20543: Fix windows and mac errors and warnings

Signed-off-by: JesusPoderoso <[email protected]>
eProsima · Apr 2, 2024 · d96313b · d96313b
1 parent 2538764
commit d96313b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/examples/cpp/hello_world/CLIParser.hpp b/examples/cpp/hello_world/CLIParser.hpp
@@ -147,12 +147,12 @@ class CLIParser
                     }
                     catch (const std::invalid_argument& e)
                     {
-                        EPROSIMA_LOG_ERROR(CLI_PARSER, "invalid sample argument for " + arg);
+                        EPROSIMA_LOG_ERROR(CLI_PARSER, "invalid sample argument for " + arg + ": " + e.what());
                         print_help(EXIT_FAILURE);
                     }
                     catch (const std::out_of_range& e)
                     {
-                        EPROSIMA_LOG_ERROR(CLI_PARSER, "sample argument out of range for " + arg);
+                        EPROSIMA_LOG_ERROR(CLI_PARSER, "sample argument out of range for " + arg + ": " + e.what());
                         print_help(EXIT_FAILURE);
                     }
                 }
@@ -193,10 +193,12 @@ class CLIParser
                 return "SIGINT";
             case SIGTERM:
                 return "SIGTERM";
+#ifndef _WIN32
             case SIGQUIT:
                 return "SIGQUIT";
             case SIGHUP:
                 return "SIGHUP";
+#endif // _WIN32
             default:
                 return "UNKNOWN SIGNAL";
         }

diff --git a/examples/cpp/hello_world/ListenerSubscriberApp.hpp b/examples/cpp/hello_world/ListenerSubscriberApp.hpp
@@ -57,10 +57,10 @@ class ListenerSubscriberApp : public Application,  public DataReaderListener
             const SubscriptionMatchedStatus& info) override;
 
     //! Run subscriber
-    virtual void run();
+    void run() override;
 
     //! Trigger the end of execution
-    virtual void stop();
+    void stop() override;
 
 private:
 

diff --git a/examples/cpp/hello_world/PublisherApp.cpp b/examples/cpp/hello_world/PublisherApp.cpp
@@ -108,13 +108,13 @@ void PublisherApp::on_publication_matched(
 {
     if (info.current_count_change == 1)
     {
-        matched_ = info.current_count;
+        matched_ = static_cast<int16_t>(info.current_count);
         std::cout << "Publisher matched." << std::endl;
         cv_.notify_one();
     }
     else if (info.current_count_change == -1)
     {
-        matched_ = info.current_count;
+        matched_ = static_cast<int16_t>(info.current_count);
         std::cout << "Publisher unmatched." << std::endl;
     }
     else

diff --git a/examples/cpp/hello_world/WaitsetSubscriberApp.hpp b/examples/cpp/hello_world/WaitsetSubscriberApp.hpp
@@ -50,10 +50,10 @@ class WaitsetSubscriberApp : public Application
     ~WaitsetSubscriberApp();
 
     //! Run subscriber
-    virtual void run();
+    void run() override;
 
     //! Trigger the end of execution
-    virtual void stop();
+    void stop() override;
 
 private: