Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciliation ignores same fingerprints #29

Open
xash opened this issue Nov 12, 2024 · 0 comments
Open

Reconciliation ignores same fingerprints #29

xash opened this issue Nov 12, 2024 · 0 comments

Comments

@xash
Copy link
Contributor

xash commented Nov 12, 2024

IIUC: iff fingerprints match, then count: 0 is set here. But this property is lost in the pipeline here. The announcer then catches all entries in the range regardless of the fingerprint and sends all entries anyway here.

Given that the spec just changed from count to is_empty anyway, this should be fixed with/after the rewrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xash