Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission #641

Closed
strengejacke opened this issue Feb 1, 2024 · 11 comments
Closed

CRAN submission #641

strengejacke opened this issue Feb 1, 2024 · 11 comments

Comments

@strengejacke
Copy link
Member

@DominiqueMakowski I think we can submit a new version to CRAN, no?
Last update is quite some time ago, and we have made several fixes in between.

@strengejacke
Copy link
Member Author

@DominiqueMakowski What are the results from win builder?

@strengejacke
Copy link
Member Author

@DominiqueMakowski ping

@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Feb 4, 2024

Sorry I missed this !

Mismatches for apparent methods not registered:
.clean_priors_and_posteriors:
function(posterior, prior, verbose, ...)
.clean_priors_and_posteriors.emm_list:
function(posterior, prior, verbose)

.clean_priors_and_posteriors:
function(posterior, prior, verbose, ...)
.clean_priors_and_posteriors.emmGrid:
function(posterior, prior, verbose)

Missing link or links in Rd file 'p_direction.Rd':
'pd_tp_p' 'density estimation

strengejacke added a commit that referenced this issue Feb 4, 2024
@strengejacke
Copy link
Member Author

Ok, should be fixed in ffd511f

@strengejacke
Copy link
Member Author

@mattansb When fixing this, I realized that the .clean_priors_and_posteriors() is called from bayesfactor_parameters.stanreg() with a parameters argument, but that argument seems to have no effect in .clean_priors_and_posteriors.stanreg()?

@strengejacke
Copy link
Member Author

I think you can submit.

mattansb added a commit that referenced this issue Feb 6, 2024
@mattansb
Copy link
Member

mattansb commented Feb 6, 2024

@strengejacke Oops, fixing that here #642

@DominiqueMakowski
Copy link
Member

submitted (with bumped version)
gosh it feels like haven't done that for years lol

@DominiqueMakowski
Copy link
Member

They are not:

Unknown, possibly misspelled, fields in DESCRIPTION:
'Remotes'

Please drop that field.

Flavor: r-devel-windows-x86_64
Check: examples, Result: NOTE
Examples with CPU (user + system) or elapsed time > 10s
user system elapsed
bayesfactor_parameters 5.17 0.14 55.17

Please reduce each example to less than 5 sec.


This 5 sec rule is starting to be a bit annoying

strengejacke added a commit that referenced this issue Feb 9, 2024
strengejacke added a commit that referenced this issue Feb 9, 2024
@strengejacke
Copy link
Member Author

I think these issues should be fixed on main.

@DominiqueMakowski
Copy link
Member

It should be on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants