box: Use isinf() and signbit() when isinff() is not available #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using bytewise comparison, use isinf() and hope it works correctly with single precision floats on the target platform; additionally, since the negative return value for negative infinities is a GNU extension, use signbit() to check if the number is a positive or negative infinity.
rmader
reviewed
Oct 13, 2020
| return min_cmp == 0 && max_cmp == 0; | ||
| float vmin[3], vmax[3]; | ||
|
|
||
| graphene_simd4f_dup_3f (box->min.value, vmin); |
There was a problem hiding this comment.
You could move these out of the #ifdef branch and save some duplicated lines (same below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using bytewise comparison, use isinf() and hope it works
correctly with single precision floats on the target platform;
additionally, since the negative return value for negative infinities is
a GNU extension, use signbit() to check if the number is a positive or
negative infinity.
Proposed changes:
is_empty()andis_infinity()methods ofgraphene_box_t