Easy: remoove _RJS from stringToBigInt_RJS

Summary:
It does not invoke the interpreter recursively. Discovered this while
annotation IR instructions for it.

Reviewed By: neildhar

Differential Revision: D42297944

fbshipit-source-id: 296a0811b55adf8652dba20395d7c1adee68c397

include/hermes/VM/Operations.h

@@ -456,7 +456,7 @@ bool isIntegralNumber(double number);
 CallResult<HermesValue> toBigInt_RJS(Runtime &runtime, Handle<> value);
 
 // ES2022 7.1.14 StringToBigInt
-CallResult<HermesValue> stringToBigInt_RJS(Runtime &runtime, Handle<> value);
+CallResult<HermesValue> stringToBigInt(Runtime &runtime, Handle<> value);
 
 // ES2022 21.2.3 Properties of the BigInt Prototype Object - thisBigIntValue
 CallResult<HermesValue> thisBigIntValue(Runtime &runtime, Handle<> value);

lib/VM/Operations.cpp

@@ -846,7 +846,7 @@ static CallResult<bool> compareBigIntAndString(
     bool (*comparator)(int)) {
   assert(rightHandle->isString() && "rhs should be string");
 
-  auto bigintRight = stringToBigInt_RJS(runtime, rightHandle);
+  auto bigintRight = stringToBigInt(runtime, rightHandle);
   if (LLVM_UNLIKELY(bigintRight == ExecutionStatus::EXCEPTION)) {
     return ExecutionStatus::EXCEPTION;
   }
@@ -1077,7 +1077,7 @@ abstractEqualityTest_RJS(Runtime &runtime, Handle<> xHandle, Handle<> yHandle) {
       // 6. If Type(x) is BigInt and Type(y) is String, then
       CASE_M_M(BigInt, Str) {
         // a. Let n be ! StringToBigInt(y).
-        auto n = stringToBigInt_RJS(runtime, y);
+        auto n = stringToBigInt(runtime, y);
         if (LLVM_UNLIKELY(n == ExecutionStatus::EXCEPTION)) {
           return ExecutionStatus::EXCEPTION;
         }
@@ -2227,7 +2227,7 @@ CallResult<HermesValue> toBigInt_RJS(Runtime &runtime, Handle<> value) {
       return *prim;
     case HermesValue::ETag::Str1:
     case HermesValue::ETag::Str2: {
-      auto n = stringToBigInt_RJS(runtime, runtime.makeHandle(*prim));
+      auto n = stringToBigInt(runtime, runtime.makeHandle(*prim));
       if (LLVM_UNLIKELY(n == ExecutionStatus::EXCEPTION)) {
         return ExecutionStatus::EXCEPTION;
       }
@@ -2243,7 +2243,7 @@ CallResult<HermesValue> toBigInt_RJS(Runtime &runtime, Handle<> value) {
   return runtime.raiseTypeError("invalid argument to BigInt()");
 }
 
-CallResult<HermesValue> stringToBigInt_RJS(Runtime &runtime, Handle<> value) {
+CallResult<HermesValue> stringToBigInt(Runtime &runtime, Handle<> value) {
   if (value->isString()) {
     auto str = value->getString();