Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library construction ontology now exists for null ontology_ids and can be updated #332

Closed
NoopDog opened this issue May 19, 2021 · 13 comments
Assignees
Labels
dataset All dataset tickets should have this label, only one ticket per dataset operations This issue is an operational task

Comments

@NoopDog
Copy link
Collaborator

NoopDog commented May 19, 2021

For context see HumanCellAtlas/dcp2#13

See rows 2,3,4 of https://docs.google.com/spreadsheets/d/1Wk7SGxEz00AkNokYv3YlFHJVF9U6THKcrvgHARsnau8/edit#gid=0

Project Detail Page project_id library_preparation_protocol_id ontology_id ontology_label text
https://data.humancellatlas.org/explore/projects/88ec040b-8705-4f77-8f41-f81e57632f7d 88ec040b-8705-4f77-8f41-f81e57632f7d 5bd07f13-2672-4a90-8ae4-97ca56b1ac23 null null sci-RNA-seq
https://data.humancellatlas.org/explore/projects/88ec040b-8705-4f77-8f41-f81e57632f7d 88ec040b-8705-4f77-8f41-f81e57632f7d 5e21e36c-f789-42f1-b81c-f8e280622d78 null null Seq-Well
https://data.humancellatlas.org/explore/projects/88ec040b-8705-4f77-8f41-f81e57632f7d 88ec040b-8705-4f77-8f41-f81e57632f7d ee388b7a-9eed-40ad-be52-9626db47a204 null null CEL-seq2

The terms sci-RNA-seq, Seq-Well, and CEL-seq2

now exist under OBI:0000711

https://www.ebi.ac.uk/ols/ontologies/efo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo/OBI_0000711

and the ontology IDs for these library preparation protocols can be updated.

@clairerye clairerye added the operations This issue is an operational task label May 19, 2021
@rays22 rays22 self-assigned this May 24, 2021
@clairerye
Copy link
Contributor

We agreed these should be updated now the terms are available and we should be able to do this is a straight forward manner using updates in the UI.

@rays22
Copy link
Contributor

rays22 commented May 28, 2021

I tried to edit the ontology labels of the library preparation protocols for this project in Ingest, but the Protocols tab failed to load on several attempts on 2021-05-28.
The tab seemed to be stuck in a state of
Loading...
for more than an hour.
On another day I will check if this failure of loading the protocols is persistent or just a one-off.

@rays22 rays22 added the dataset All dataset tickets should have this label, only one ticket per dataset label May 28, 2021
@rays22
Copy link
Contributor

rays22 commented May 28, 2021

The project has a status of Complete in Ingest. I need an EBI HCA dev to set it to Valid so that I can do any metadata edits in the UI.

@rays22
Copy link
Contributor

rays22 commented Jun 1, 2021

  • I have managed to add the missing library protocol method ontology terms in Ingest UI.
  • EFO:0010550 sci-RNA-seq
    "library_construction_method" : {
      "ontology" : "EFO:0010550",
      "ontology_label" : "sci-RNA-seq",
      "text" : "sci-RNA-seq"
    },
  • EFO:0008919 Seq-Well
    "library_construction_method" : {
      "ontology" : "EFO:0008919",
      "ontology_label" : "Seq-Well",
      "text" : "Seq-Well"
    },
  • EFO:0010010 CEL-seq2
    "library_construction_method" : {
      "ontology" : "EFO:0010010",
      "ontology_label" : "CEL-seq2",
      "text" : "CEL-seq2"
    },
  • I still need the project status to be reverted from Complete to Valid before I can export the update.

@rays22
Copy link
Contributor

rays22 commented Jun 4, 2021

I am still blocked from exporting this update, because of the Complete status of the project.

@clairerye
Copy link
Contributor

clairerye commented Jun 7, 2021

@yusra-haider are you able to look into this please? - sorry I am way behind. I see you have done it already

@rays22
Copy link
Contributor

rays22 commented Jun 10, 2021

@yusra-haider has changed the project status to Valid, but I was told to wait with exporting the updates, because this is a DCP1 project.

@clairerye
Copy link
Contributor

Thanks, it has now been clarified so we can go ahead and export. Slack conversation - https://embl-ebi-ait.slack.com/archives/C01360XN04S/p1623070775056500

@rays22
Copy link
Contributor

rays22 commented Jun 11, 2021

The export of the update is blocked by unresponsive Ingest project page.

@rays22 rays22 added the internally blocked Issue blocked by something within DCP label Jun 11, 2021
@yusra-haider
Copy link
Contributor

yusra-haider commented Jun 14, 2021

@clairerye , @rays22

We can't export it yet, it's a dcp 1 dataset and requires that I make changes to the dcpVersion values in the database.

The referenced slack conversation was just me confirming that we can export dcp 1 metadata to the staging area for dcp 2 projects

Please wait till I fix the database values. I will export it, monitor the export and send an update

@clairerye
Copy link
Contributor

ok thanks, apologies I misunderstood the slack thread

@yusra-haider
Copy link
Contributor

yusra-haider commented Jun 14, 2021

@rays22
Copy link
Contributor

rays22 commented Jun 15, 2021

Thank you @yusra-haider .
I have filled in an import request for this update targeting release 7.

@rays22 rays22 removed the internally blocked Issue blocked by something within DCP label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset All dataset tickets should have this label, only one ticket per dataset operations This issue is an operational task
Projects
None yet
Development

No branches or pull requests

5 participants