Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for any custom order type and for date ranges #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add options for any custom order type and for date ranges #27

wants to merge 6 commits into from

Conversation

nsushkin
Copy link

@nsushkin nsushkin commented Nov 17, 2021 •
edited
Loading

  1. I merge styppo's support for start and end dates without merging any other changes in the same commit
  2. I implement arbitrary order types as originally proposed by @reva in Implement OrderType as interface to allow arbitrary order types #15
  3. Package client as a single jar
  4. Do not crash on no data, instead warn and return exit code 2

Nicholas Sushkin added 6 commits November 17, 2021 13:41
Merge support for download requests with start/end date from styppo
554c7ce 
- Merged styppo's commit 014df1e
  limited to only changes related to the support for start and end
  dates
Add support for any custom order type
337d063 
- Support any bank's custom order types via new options --download
  <arg> and --upload <arg>

- Add logging of the order type
Package Ebics Client as a single jar
f5f440a 
- Use executable-packer-maven-plugin to package the project in a
  single jar. This plugin uses a Jar-in-Jar approach which does not
  break digital signature of the Bouncy Castle JCE provider jar. Run
  "mvn package" to package and run "java -jar ebics*.jar" to execute
  EbicsClient main class.
When download request has no data, warn instead of crashing
1b03d39 
- When requesting order types that download data, NoDataException is a
  common occurrence. In this case, the client writes a warning to the
  log and exits with error code 2 (to distinguish the condition from
  other errors which return error code 1).

- When a file download succeeds, the client logs the success.

- Introduce new method EbicsClient.fetchFileIfAvailable which wraps
  fetchFile with warn and log.
Add options to specify configuration directory and print version
9540c01 
- Add option --configuration-directory <arg> to override the default
  value of ${user.home}/ebics/client

- Add option --version to print version information
Implement override of configuration properties with the system ones
e298c67 
- In DefaultConfiguration.java, any configuration property that comes
  from a key in the configuration file can be overriden with a system
  property with the same key. For example, specify
  -Dlog.dir.name=/var/log to override the default ebics/client/log
  directory.

- In DefaultConfiguration.java, if a property is a compound of a
  directory name and a file name, specifying an absolute file name
  overrides the directory name. For example,
  -Dtraces.dir.name=/var/local/traces overrides the default value of
  traces under ebics/client/users/USERNAME.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nsushkin