canmatrix.formats.loads() fails due to undefined StringIO

[altendky]

With 0.6 released where should a fix get committed? If the dev branch lives on should it get renamed to just dev?

Along with an import, presumably there's some 2/3 considerations to be made here.

canmatrix/canmatrix/formats.py

Line 41 in 1ee97a0

fileObject = StringIO.StringIO[string]

[ebroecker]

rename to dev is the right way.

[ebroecker]

should be fixed - could you please review?

[ebroecker]

@altendky
Is this still open or can we close this issue?

[altendky]

Sorry I missed the first query. Yes, the described issue appears to be resolved, but I'm not big on version conditional and variant functionality. Both Py2 and 3 have 'byte sequences' and 'character sequences' and this function should take one of those in both versions.

I guess the first question is do we want bytes or characters being passed? I suppose we end up with a special case where we likely want either two functions or just bytes due to the fancy-schmancy mixed encoding support we have. If just one function it ought to be loadb() and use io.BytesIO in both Py2 and Py3 with no version or type checking or str->bytes encoding.

http://python-future.org/compatible_idioms.html#stringio
http://python-future.org/compatible_idioms.html#stringio-module

(yes, this could be a separate ticket or just ignored)

[ebroecker]

want to do this after 0.7

[ebroecker]

I took it into #236