Skip to content

Commit

Permalink
Workflow errors (#169)
Browse files Browse the repository at this point in the history
* Fix for coverage and lint workflow jobs
- src/benchmarkstt/core.py : E741 ambiguous variable name 'l'
- setup.py : jsonrpcserver max version 5 - error Protocol import from typing for python >= 3.8

* github workflows exclude os/python version combinations

---------

Co-authored-by: Pierre <[email protected]>
  • Loading branch information
aro-max and pierreEBU authored Apr 16, 2024
1 parent 2ceb86b commit d082169
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.5, 3.6, 3.7, 3.8, 3.9]
exclude:
- os: macos-latest
python-version: 3.5
- os: windows-latest
python-version: 3.5
- os: ubuntu-latest
python-version: 3.5
- os: macos-latest
python-version: 3.6
- os: windows-latest
python-version: 3.6
- os: ubuntu-latest
python-version: 3.6

runs-on: ${{matrix.os}}

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def filter_requirements(line):
install_requires=[
'MarkupSafe>=1.0',
'Flask>=1.0.2',
'jsonrpcserver>=4.0.1',
'jsonrpcserver>=4.0.1,<5',
'gunicorn>=19.9.0',
'docutils>=0.14',
'editdistance>=0.5.3',
Expand Down
2 changes: 1 addition & 1 deletion src/benchmarkstt/metrics/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def __generate_list_entity(self, list_parsed):
index_entities.extend(index_entity)

# sort on the position of the first part of the entity
index_entities.sort(key=lambda l: l[0])
index_entities.sort(key=lambda elem: elem[0])

# copy-past the entity found in the list
for k_list in index_entities:
Expand Down

0 comments on commit d082169

Please sign in to comment.