Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Python 3 #488

Open
nigelmegitt opened this issue Jul 15, 2019 · 1 comment
Open

Move to Python 3 #488

nigelmegitt opened this issue Jul 15, 2019 · 1 comment

Comments

@nigelmegitt
Copy link
Collaborator

nigelmegitt commented Jul 15, 2019

Python 2.7 is going out of support, so we need to move to Python 3.

Issues currently:

  • ebu_tt_live/utils.py", line 117 uses async as a function parameter label, but in python 3 it is a reserved keyword. Change the label.
  • ebu_tt_live/utils.py", line 4 uses Queue but it should be queue - python 3 is case sensitive.
  • pyxb generates ebu_tt_live/bindingsbut the _ttm module cannot be imported.
  • Python3 has different approaches to filters and maps which create different behaviours.
@nigelmegitt
Copy link
Collaborator Author

#489 fixes the issues but the twisted websocket tests fail to a greater or lesser degree, and it isn't clear why - I suspect something has changed in the twisted or pytest or both, or the way that pytest tests twisted deferreds more generally. But I'm slightly guessing.

nigelmegitt added a commit that referenced this issue Oct 11, 2019
Create first cut Python3 build branch, closes #488 when merged into master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant