extra BS2076-2 changes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other types have default ImportanceData objects (not None), so this is more consistent
all blocks now have importance, so this only doesn't apply to HOA, which doesn't have blocks in rendering items
- test filter_by_importance rather than an implementation detail - check that the whole type metadata is copied - make it possible to use the same structure for other single-channel types
- use evolve instead of modifying data - use a generic MetadataSourceMap instead of MetadataSourceImportanceFilter
tomjnixon
force-pushed
the
bs2076-2_extras
branch
2 times, most recently
from
9ef5c7d to
1b72d46
Compare
tomjnixon
force-pushed
the
bs2076-2_extras
branch
from
1b72d46 to
090c4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bits and pieces related to BS.2076-2 support spotted while spec-writing:
also, validate that floating-point values in the data model are not infinite or NaN