Fix pack allocation #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #53 The specific bug is that whenever the result would contain multiple distinct packs which only contain silent channels, multiple equivalent solutions would be produced. This could cause an "Ambiguous format references" error when the references from an audioObject are not in fact ambiguous. The data that triggers this is not useful, and causes an error (rather than incorrect behaviour), so it was likely never triggered in the wild. When allocating new packs for silent tracks, the packs need to be allocated in order, to avoid allocating both [p1, p2] and [p2, p1] with silent tracks, as in the original bug. This is implemented by modifying the list of possible packs to allocate in subsequent steps, by creating remaining_packs in candidate_new_packs, and threading that through.
this will be used for testing the main implementation the intent was to make this much simpler than the main implementation, but that wasn't possible
add a test helper which checks the results of all implementations against each other, and some basic properties (count or equality)
tomjnixon
force-pushed
the
fix_pack_allocation
branch
from
d7955b8 to
f47fb09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the root cause of #53, and improves the testing around this