Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of audioTrackNumber and numberOfAudioTracks #369

Open
JuergenGrupp opened this issue Nov 11, 2024 · 1 comment
Open

Renaming of audioTrackNumber and numberOfAudioTracks #369

JuergenGrupp opened this issue Nov 11, 2024 · 1 comment

Comments

@JuergenGrupp
Copy link
Collaborator

The two properties audioTrackNumber and numberOfAudioTracks use the term number in different meanings. We need to clarify this by renaming them to hasAudioTrackIndex and hasTotalNumberOfAudioTracks. Additionally both properties take only positive integers, so their data type should become xsd:nonNegativeInteger.
The same applies to videoTrackNumber and numberOfVideoTracks: We should rename them to hasVideoTrackIndex and hasTotalNumberOfVideoTracks
This issue replaces #343 by @MarcAntoine-Arnaud

@JuergenGrupp
Copy link
Collaborator Author

Another concern: Which classes should carry the ...Index and the ..TotalNumberOf.. properties? Here's my proposal:
The ...Index properties are describing the AudioTrack and the VideoTrack directly and should be placed in subclasses of Track, and defined as subproperties of a trackIndex property in the class Track.
Whereas the ...TotalNumberOf... properties should be defined in MediaRessource as the object that contains the countable tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant