From ec93bcfe057d4e4f6374cce77eb13690db36ebf3 Mon Sep 17 00:00:00 2001
From: Alois Zoitl <alois.zoitl@gmx.at>
Date: Sun, 1 Dec 2024 22:35:01 +0100
Subject: [PATCH] Removed last remaining virtual group interface code

In the toolbar was still a toggle virtual group interface button. This
is now removed as well as all code associated with it.
---
 .../plugin.xml                                | 16 +--------
 .../ToggleVirtualGroupInterfaceHandler.java   | 35 -------------------
 .../ui/preferences/PreferenceConstants.java   |  3 --
 3 files changed, 1 insertion(+), 53 deletions(-)
 delete mode 100644 plugins/org.eclipse.fordiac.ide.application/src/org/eclipse/fordiac/ide/application/handlers/ToggleVirtualGroupInterfaceHandler.java

diff --git a/plugins/org.eclipse.fordiac.ide.application/plugin.xml b/plugins/org.eclipse.fordiac.ide.application/plugin.xml
index b06a0d9513..0e9b6523d2 100644
--- a/plugins/org.eclipse.fordiac.ide.application/plugin.xml
+++ b/plugins/org.eclipse.fordiac.ide.application/plugin.xml
@@ -466,14 +466,6 @@
              id="org.eclipse.fordiac.ide.application.commands.toggleConnections"
              name="Toggle Connections Visibility">
     </command>
-    <command categoryId="org.eclipse.fordiac.ide.commands.category"
-             defaultHandler="org.eclipse.fordiac.ide.application.handlers.ToggleVirtualGroupInterfaceHandler"
-             id="org.eclipse.fordiac.ide.application.commands.toggleVirtualGroupInterfaces"
-             name="Toggle Virtual Group Interfaces">
-      <state class="org.eclipse.ui.handlers.RegistryToggleState"
-             id="org.eclipse.ui.commands.toggleState">
-      </state>
-    </command>
     <command categoryId="org.eclipse.fordiac.ide.commands.category"
              defaultHandler="org.eclipse.fordiac.ide.application.handlers.InsertFB"
              id="org.eclipse.fordiac.ide.application.commands.insertFB"
@@ -1165,13 +1157,7 @@
                  icon="fordiacimage://ICON_FB"
                  id="org.eclipse.fordiac.ide.application.toolbars.fordiacToolbar"
                  tooltip="Clear Focus-On">
-        </command>
-        <command commandId="org.eclipse.fordiac.ide.application.commands.toggleVirtualGroupInterfaces"
-                 icon="fordiacimage://ICON_HIDE_EVENT"
-                 id="org.eclipse.fordiac.ide.application.toolbars.fordiacToolbar"
-                 tooltip="Toggle Virtual Group Interfaces"
-                 style="toggle">
-        </command>
+        </command>        
       </toolbar>
     </menuContribution>
     <menuContribution locationURI="toolbar:org.eclipse.ui.workbench.navigate">
diff --git a/plugins/org.eclipse.fordiac.ide.application/src/org/eclipse/fordiac/ide/application/handlers/ToggleVirtualGroupInterfaceHandler.java b/plugins/org.eclipse.fordiac.ide.application/src/org/eclipse/fordiac/ide/application/handlers/ToggleVirtualGroupInterfaceHandler.java
deleted file mode 100644
index 65516ca51c..0000000000
--- a/plugins/org.eclipse.fordiac.ide.application/src/org/eclipse/fordiac/ide/application/handlers/ToggleVirtualGroupInterfaceHandler.java
+++ /dev/null
@@ -1,35 +0,0 @@
-/*******************************************************************************
- * Copyright (c) 2023 Primetals Technologies Austria GmbH
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License 2.0 which is available at
- * http://www.eclipse.org/legal/epl-2.0.
- *
- * SPDX-License-Identifier: EPL-2.0
- *
- * Contributors:
- *   Daniel Lindhuber
- *     - initial API and implementation and/or initial documentation
- *******************************************************************************/
-package org.eclipse.fordiac.ide.application.handlers;
-
-import org.eclipse.core.commands.AbstractHandler;
-import org.eclipse.core.commands.Command;
-import org.eclipse.core.commands.ExecutionEvent;
-import org.eclipse.core.commands.ExecutionException;
-import org.eclipse.core.runtime.Status;
-import org.eclipse.fordiac.ide.ui.UIPlugin;
-import org.eclipse.fordiac.ide.ui.preferences.PreferenceConstants;
-import org.eclipse.ui.handlers.HandlerUtil;
-
-public class ToggleVirtualGroupInterfaceHandler extends AbstractHandler {
-
-	@Override
-	public Object execute(final ExecutionEvent event) throws ExecutionException {
-		final Command command = event.getCommand();
-		final boolean oldValue = HandlerUtil.toggleCommandState(command);
-		UIPlugin.getDefault().getPreferenceStore().setValue(PreferenceConstants.P_TOGGLE_VIRTUAL_GROUP_INTERFACES, !oldValue);
-		return Status.OK_STATUS;
-	}
-
-}
diff --git a/plugins/org.eclipse.fordiac.ide.ui/src/org/eclipse/fordiac/ide/ui/preferences/PreferenceConstants.java b/plugins/org.eclipse.fordiac.ide.ui/src/org/eclipse/fordiac/ide/ui/preferences/PreferenceConstants.java
index 136b9a63c3..663aafdf58 100644
--- a/plugins/org.eclipse.fordiac.ide.ui/src/org/eclipse/fordiac/ide/ui/preferences/PreferenceConstants.java
+++ b/plugins/org.eclipse.fordiac.ide.ui/src/org/eclipse/fordiac/ide/ui/preferences/PreferenceConstants.java
@@ -48,9 +48,6 @@ public final class PreferenceConstants {
 	/** The Constant P_HIDE_DATA_CON. */
 	public static final String P_HIDE_DATA_CON = "hideDataConnections";//$NON-NLS-1$
 
-	/** The Constant P_TOGGLE_VIRTUAL_GROUP_INTERFACES. */
-	public static final String P_TOGGLE_VIRTUAL_GROUP_INTERFACES = "toggleVirtualGroupInterfaces";//$NON-NLS-1$
-
 	/** The Constant P_TOGGLE_JUMP_STEP. */
 	public static final String P_TOGGLE_JUMP_STEP = "toggleJumpStep";//$NON-NLS-1$