Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a concept for yaml/json interface of Ankaios #313

Open
3 tasks
krucod3 opened this issue Jul 10, 2024 · 1 comment
Open
3 tasks

Create a concept for yaml/json interface of Ankaios #313

krucod3 opened this issue Jul 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request. Issue will appear in the change log "Features"
Milestone

Comments

@krucod3
Copy link
Contributor

krucod3 commented Jul 10, 2024

Description

Currently the server and the ank CLI read a text based configuration (manifest). The CLI can also output the current configuration as json/yaml. The serialization/deserialization is achieved by tagging some Rust structs with serde attributes.

Since optional data sent over gRPC should be empty and not filled with defaults, we switched to only using the protoBuf generated objects in #22. Annotating them correctly to get a proper result is very hard and requires manual serialization for enums. As a workaround we switched to special objects for the serialization.

We have to unify all objects and develop a strategy how we define our interfaces. At the end we need schemas for the json/yaml data s.t. we are sure the API is fixed.

Goals

Final result

Summary

To be filled when the final solution is sketched.

Tasks

  • Task 1
  • Task 2
  • ...
@krucod3 krucod3 added the enhancement New feature or request. Issue will appear in the change log "Features" label Jul 10, 2024
@krucod3 krucod3 added this to the v0.6 milestone Jul 11, 2024
@inf17101
Copy link
Contributor

inf17101 commented Jul 11, 2024

For these two requirements there is no impl and test linked (this fits here to the interfaces, we need a verification scheme and tests):

  • swdd~stored-workload-spec-parses-yaml~1
  • swdd~stored-workload-spec-checks-unique-name~1

@krucod3 krucod3 self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Issue will appear in the change log "Features"
Projects
None yet
Development

No branches or pull requests

2 participants