This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Attribution document bug with unicodes #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AttributionDocumentGenerator uses the Times-Roman font if no font is provided in the template bundle. To avoid the use of a default font which doesn't support some glyphs, the open source font NotoSans is added to the basic template bundle. In addition, the template PDF files were edited with the new font and re-exported. Signed-off-by: Onur Demirci <[email protected]>
The AttributionDocumentGenerator cannot handle unicodes like tabs (U+0009) and newlines (U+2028, U+2029) for layour purposes. Therefore it will be replaced manually. In addition, some unavailable unicodes are also replaced. Resolves eclipse-archived#548. Signed-off-by: Onur Demirci <[email protected]>
|
We close this PR for now because it's not solvable elegantly in antenna. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #548.
Request Reviewer
@sschuberth
Type of Change
bug fix
Checklist
Must: