-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jsign without google credentials #594
Comments
this makes perfect sense. In our use-case we were using jsign exclusively with Google KMS as signing providers, but it makes sense to make this configurable. |
may I ask you for which use-case your are using the window signer and how do you run / deploy it? Our current deployment script is heavily tailored for our use-case, but we can make that more general if there is a need. |
I sign the customized executable and the installer. Both by the maven-plugin or directly via rest requests in gradle builds. |
In JSigner.java the googleAccessToken is required always, even if no google credentials are provided. This leads to RuntimeException in
#googleAccessToken()
.The certificate chain is optional for JSign, if it's stored in the PKCS11 module.
I've changed the code to
The text was updated successfully, but these errors were encountered: