Incorrect address (pc) resolution in DisassembleRequest #340
Comments
jonahgraham
pushed a commit
that referenced
this issue
Dec 10, 2024
This is an update for the disassembleRequest logic in the debug adapter. This implementation is covering the scenarios discussed at the #340 . Notes: - The previous implementation was covering a scenario for the endMemoryReference argument. I couldn't find the argument in the DAP specifications. Since this argument doesn't exists on the current DAP protocol and only existed for the now deleted Eclipse CDT front end, this field support has been removed. - The main thing this code changes is handling negative offsets from the memory reference, something the original code did not do and wasn't used by vscode when the original code was written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During the debug session, when user navigates and opens the
Disassembly Viewin the VSCode, the Disassembly View focuses on an incorrect line when it is compared program counter (pc) register as shown above:After a review, I found that the current implementation of the
disassembleRequestmethod at theGDBDebugSessionBaseclass are not handling theinstructionOffsetparameters. It seems thedisassembleRequestimplementation requires to be updated to match the DAP reference.https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble
@jonahgraham and I already discussed the issue previously, planning to propose an update to solve the issue.
The text was updated successfully, but these errors were encountered: