From 5d7a7947a9a944104b42753469b71ae0ff67c061 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torbj=C3=B6rn=20Svensson?= <torbjorn.svensson@st.com>
Date: Fri, 11 Oct 2024 21:20:36 +0200
Subject: [PATCH] Classify unrecognized command line options as an error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Contributed by STMicroelectronics

Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
---
 .../internal/errorparsers/tests/GCCErrorParserTests.java | 9 +++++++++
 core/org.eclipse.cdt.core/plugin.properties              | 1 +
 core/org.eclipse.cdt.core/plugin.xml                     | 1 +
 3 files changed, 11 insertions(+)

diff --git a/core/org.eclipse.cdt.core.tests/misc/org/eclipse/cdt/core/internal/errorparsers/tests/GCCErrorParserTests.java b/core/org.eclipse.cdt.core.tests/misc/org/eclipse/cdt/core/internal/errorparsers/tests/GCCErrorParserTests.java
index c9423c67266..1e739356952 100644
--- a/core/org.eclipse.cdt.core.tests/misc/org/eclipse/cdt/core/internal/errorparsers/tests/GCCErrorParserTests.java
+++ b/core/org.eclipse.cdt.core.tests/misc/org/eclipse/cdt/core/internal/errorparsers/tests/GCCErrorParserTests.java
@@ -232,4 +232,13 @@ public void testGccErrorMessages_InConstexprExpansion() throws IOException {
 						"unused parameter 'bitrate' [-Wunused-parameter]" },
 				new String[] { GCC_ERROR_PARSER_ID });
 	}
+
+	@Test
+	public void testGccErrorMessages_UnrecognizedCommandLineOption() throws IOException {
+		runParserTest(new String[] { "arm-none-eabi-gcc: error: unrecognized command-line option '--foobar'" }, 1, // errors
+				0, //warnings
+				0, //infos
+				null, new String[] { "unrecognized command-line option '--foobar'" },
+				new String[] { GCC_ERROR_PARSER_ID });
+	}
 }
diff --git a/core/org.eclipse.cdt.core/plugin.properties b/core/org.eclipse.cdt.core/plugin.properties
index ebae3197fbe..23e4fa551d1 100644
--- a/core/org.eclipse.cdt.core/plugin.properties
+++ b/core/org.eclipse.cdt.core/plugin.properties
@@ -67,6 +67,7 @@ CDTGNUCErrorParser.regex.ParseErrorBefore=(.*?):(\\d+):(\\d+:)? (parse error bef
 CDTGNUCErrorParser.regex.ErrorUndeclared=(.*?):(\\d+):(\\d+:)? [Ee]rror: ([`'"](.*)['"] undeclared .*)
 CDTGNUCErrorParser.regex.ErrorConflictingTypesFor=(.*?):(\\d+):(\\d+:)? [Ee]rror: (conflicting types for .*[`'"](.*)['"].*)
 CDTGNUCErrorParser.regex.GenericError=(.*?):(\\d+):(\\d+:)?\\s*(([Ee]rror)|(ERROR)): (.*)
+CDTGNUCErrorParser.regex.InvocationError=(.*?): (([Ee]rror)|(ERROR)): (.*)
 CDTGNUCErrorParser.regex.DefinedButNotUsed=(.*?):(\\d+):(\\d+:)? [Ww]arning: ([`'"](.*)['"] defined but not used.*)
 CDTGNUCErrorParser.regex.WarningConflictingTypesFor=(.*?):(\\d+):(\\d+:)? [Ww]arning: (conflicting types for .*[`'"](.*)['"].*)
 CDTGNUCErrorParser.regex.GenericWarning=(.*?):(\\d+):(\\d+:)?\\s*(([Ww]arning)|(WARNING)): (.*)
diff --git a/core/org.eclipse.cdt.core/plugin.xml b/core/org.eclipse.cdt.core/plugin.xml
index ddf299db509..989514fd5fe 100644
--- a/core/org.eclipse.cdt.core/plugin.xml
+++ b/core/org.eclipse.cdt.core/plugin.xml
@@ -241,6 +241,7 @@
                regex="%CDTGNUCErrorParser.regex.GenericError"
                severity="Error"
                variable-expr="$3"/>
+         <pattern description-expr="$5" eat-processed-line="true" file-expr="" line-expr="" regex="%CDTGNUCErrorParser.regex.InvocationError" severity="Error" variable-expr=""/>
          <pattern description-expr="$7" eat-processed-line="true" file-expr="$1" line-expr="$2" regex="%CDTGNUCErrorParser.regex.GenericWarning" severity="Warning"/>
          <pattern description-expr="$10" eat-processed-line="true" file-expr="$1" line-expr="$2" regex="%CDTGNUCErrorParser.regex.GenericInfo" severity="Info"/>
          <pattern description-expr="$4" eat-processed-line="true" file-expr="$1" line-expr="$2" regex="%CDTGNUCErrorParser.regex.OtherError" severity="Error"/>