Configurable #fragments to send on NACK of sample #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the hard-coded policy of responding to a NACK of a large sample with only the first fragment of that sample into one where the number is configurable. The default is 1 and so there is by default no change in behavior. Because of the change, the code handling HeartbeatFrag messages in the case of a retransmit is now no longer dead code. Signed-off-by: Erik Boasson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the hard-coded policy of responding to a NACK of a large sample with only the first fragment of that sample into one where the number is configurable. The default is 1 and so there is by default no change in behavior.
Because of the change, the code handling HeartbeatFrag messages in the case of a retransmit is now no longer dead code.